Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release process documentation #447

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Add release process documentation #447

merged 1 commit into from
Nov 8, 2019

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Nov 8, 2019 •
edited
Loading

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2019
@chmouel chmouel force-pushed the release-process-doc branch 2 times, most recently from c769ded to 8d7eacd Compare November 8, 2019 12:03
@chmouel
Copy link
Member Author

chmouel commented Nov 8, 2019

/test pull-tekton-cli-build-tests

@chmouel
Copy link
Member Author

chmouel commented Nov 8, 2019

/retest

@piyush-garg
Copy link
Contributor

/test pull-tekton-cli-build-tests

piyush-garg
piyush-garg approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2019
piyush-garg
piyush-garg reviewed Nov 8, 2019
View reviewed changes
RELEASE_PROCESS.md Outdated
- you need to edit the Changelog according to the other templates in there,
usually you may want to do this in hackmd so you can have other cli
maintainers do this with you. an example
[here](https://hackmd.io/Gj9bxTh0Qn6kOaEx8gjsJg?edit).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try updating the url to https://hackmd.io/@chmouel/SykvrTGoB/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol i made a edit and pushed --force but forgot to save in my editor!

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2019
vdemeester
vdemeester approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

RELEASE_PROCESS.md

- You need to be a tektoncd-cli [OWNERS](OWNERS) to be able to push the new branch

- You need to have your own tekton cluster, under `minikube`, `gcp` or other means.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: at some point, we want to automate release on the dogfooding cluster 😉 but we are not yet there for sure 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

RELEASE_PROCESS.md Outdated
- Announce and spread the love on twitter, make sure you tag
[@tektoncd](https://twitter.com/tektoncd) account so you get retweeted and
perhaps add the major new feature in the tweet. See [here](https://twitter.com/chmouel/status/1177172542144036869) for an example.
Do not fear to add a bunch of emojis 🎉🥳. Ask @vdmeester for tips 🤣.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 8, 2019
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2019
vdemeester
vdemeester approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2019
@chmouel
Add Release process documentation
bd7eb54 
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2019
piyush-garg
piyush-garg approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@piyush-garg
Copy link
Contributor

/test pull-tekton-cli-unit-tests

@tekton-robot tekton-robot merged commit 8d9f8f3 into tektoncd:master Nov 8, 2019
chmouel added a commit that referenced this pull request Nov 22, 2019
@chmouel
New version v0.5.1
13bf66a 
#445 | [Chmouel Boudjnah] Fix brew install from tap | 2019/11/08-05:20
#446 | [Chmouel Boudjnah] Update README to 0.5.0 | 2019/11/08-07:01
#443 | [Piyush Garg] Show param default value in task describe | 2019/11/08-07:45
#443 | [Piyush Garg] Change DEFAULT_VALUE to DEFAULT VALUE | 2019/11/08-07:45
#447 | [Chmouel Boudjnah] Add Release process documentation | 2019/11/08-08:23
#449 | [Vincent Demeester] Linting yamls with yamllint 🏷 | 2019/11/08-10:09
#452 | [Piyush Garg] Add cloudEvent resource support to start command | 2019/11/11-22:56
#457 | [Piyush Garg] Fix resource creation failure in case of multiple | 2019/11/13-00:49
#450 | [danielhelfand] show status of steps with taskrun describe | 2019/11/13-08:00
#461 | [Piyush Garg] Update go.sum | 2019/11/14-03:01
null | [Vincent Demeester] Bump plumbing to latest changes 🔗 | 2019/11/14-04:36
null | [Dan Lorenc] Add a --filename parameter to 'tkn tasks start'. | 2019/11/15-02:38
null | [Piyush Garg] Fix interactive input params on pipeline start | 2019/11/15-03:54
null | [Daniel Helfand] include os and version in issue template | 2019/11/18-14:57
null | [Chmouel Boudjnah] Add Installtion instruction when compiling from source | 2019/11/20-06:23
null | [Navid Shaikh] Uses vendored deps while building the binary in Makefile | 2019/11/20-07:58
null | [Daniel Helfand] add check in pr logs for if condition available | 2019/11/21-02:53

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel chmouel deleted the release-process-doc branch June 27, 2021 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@piyush-garg piyush-garg piyush-garg approved these changes

@danielhelfand danielhelfand Awaiting requested review from danielhelfand

@hrishin hrishin Awaiting requested review from hrishin

Assignees

@vdemeester vdemeester

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chmouel @piyush-garg @tekton-robot @vdemeester @googlebot