Use serviceAccountName instead of serviceAccount #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serviceAccount is not working since 0.9.x Closes tektoncd#494 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
tekton-robot
requested review from
danielhelfand,
hrishin,
sthaha and
vdemeester
tekton-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-cli-unit-tests |
5 tasks
|
/retest 🙄 we need to talk abotu those flaky tests at our first meeting agenda 🙏 |
Yes, it's always those same two unit tests. |
|
We have talked a bit offline with @pradeepitm12 and @piyush-garg let's try to put this for next week agenda, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
serviceAccountis not working anmore since 0.9.x let's rename it toserviceAccountNameas it should be™️Closes #494
Related proper long term detection of those failures: #496
/cc @vdemeester @hrishin @sthaha @danielhelfand