Fix to auto select the first pipeline when only one is available #563

chmouel · 2020-01-01T14:19:38Z

For whatever code change happened before it wasn't auto selecting the first
pipeline.

Add a test to test it explicitely, I suppose (because i wrote it) that
TestLogs_have_one_get_one was supposed to test that but for whatever reason it's
a buggy one (those tests are just way too heavy and i have no idea what's going
on between all the test setups)

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
[-] Includes docs (if user facing)
[-] Regenerate the manpages and docs with make docs and make man if needed.
Run the code checkers with make check
Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

chmouel · 2020-01-01T15:50:24Z

/retest

chmouel · 2020-01-01T23:18:12Z

/retest

piyush-garg · 2020-01-02T14:58:20Z

@chmouel AFAIR, you did for auto-choosing the pipelinerun if only one in PR, it was not for the pipeline. But this also seems nice to have.

vdemeester

/lgtm
/retest

vdemeester · 2020-01-02T15:45:36Z

/test pull-tekton-cli-unit-tests

piyush-garg · 2020-01-06T06:14:40Z

pkg/cmd/pipeline/logs.go

-	if err := opts.Ask(options.ResourceNamePipeline, ps); err != nil {
+	if len(ps) == 1 {
+		opts.PipelineName = strings.Fields(ps[0])[0]
+	} else if err := opts.Ask(options.ResourceNamePipeline, ps); err != nil {
 		return nil


Not related to your changes, but can we fix in this PR, we need to return an error in spite of nil

Any chances you can capture in a new issue instead?

chmouel · 2020-01-06T17:59:08Z

those test flakyness are just getting a bit much

For whatever code change happened before it wasn't auto selecting the first pipeline. Add a test to test it explicitely, I suppose (because i wrote it) that TestLogs_have_one_get_one was supposed to test that but for whatever reason it's a buggy one (those tests are just way too heavy and i have no idea what's going on between all the test setups) Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

chmouel · 2020-01-15T10:19:53Z

Fixed my emacs, i can finally fix this patch 🏩

vdemeester

/lgtm

chmouel · 2020-01-15T10:58:32Z

/retest

chmouel · 2020-01-15T11:31:25Z

I am reaching my breaking point with the flakeys 😓

/retest

chmouel · 2020-01-15T11:57:03Z

/retest

chmouel · 2020-01-15T12:13:35Z

Finally found a youtube "tuto" on how to avoid flakyness in test, https://www.youtube.com/watch?v=dQw4w9WgXcQ

/retest

chmouel · 2020-01-15T12:36:10Z

/retest

vdemeester · 2020-01-15T15:07:25Z

/retest

This test is crashing due of goexpect not getting the proper VT Let's disable it for now Example of crash : === I0115 15:19:48.678] === RUN TestPipelineLog_Interactive I0115 15:19:48.679] === RUN TestPipelineLog_Interactive/Select_pipeline_output-pipeline_and_output-pipeline-run-2_logs I0115 15:19:48.679] panic: test timed out after 10m0s I0115 15:19:48.679] I0115 15:19:48.679] goroutine 86 [running]: I0115 15:19:48.679] testing.(*M).startAlarm.func1() I0115 15:19:48.679] /usr/local/go/src/testing/testing.go:1377 +0x11c I0115 15:19:48.679] created by time.goFunc I0115 15:19:48.680] /usr/local/go/src/time/sleep.go:168 +0x52 I0115 15:19:48.680] I0115 15:19:48.680] goroutine 1 [chan receive, 9 minutes]: I0115 15:19:48.680] testing.(*T).Run(0xc0000f4d00, 0x222721f, 0x1b, 0x22b2708, 0x1) I0115 15:19:48.680] /usr/local/go/src/testing/testing.go:961 +0x68a I0115 15:19:48.680] testing.runTests.func1(0xc0000f4d00) I0115 15:19:48.680] /usr/local/go/src/testing/testing.go:1202 +0xa7 I0115 15:19:48.681] testing.tRunner(0xc0000f4d00, 0xc000597d40) I0115 15:19:48.681] /usr/local/go/src/testing/testing.go:909 +0x19a I0115 15:19:48.681] testing.runTests(0xc0005d49c0, 0x3353740, 0x1e, 0x1e, 0x0) I0115 15:19:48.681] /usr/local/go/src/testing/testing.go:1200 +0x522 I0115 15:19:48.681] testing.(*M).Run(0xc000416680, 0x0) I0115 15:19:48.681] /usr/local/go/src/testing/testing.go:1117 +0x300 I0115 15:19:48.681] main.main() I0115 15:19:48.682] _testmain.go:102 +0x224 I0115 15:19:48.682] I0115 15:19:48.682] goroutine 6 [chan receive]: I0115 15:19:48.682] k8s.io/klog.(*loggingT).flushDaemon(0x3364000) I0115 15:19:48.682] /go/pkg/mod/k8s.io/klog@v1.0.0/klog.go:1010 +0xae I0115 15:19:48.682] created by k8s.io/klog.init.0 I0115 15:19:48.682] /go/pkg/mod/k8s.io/klog@v1.0.0/klog.go:411 +0x18f I0115 15:19:48.682] I0115 15:19:48.683] goroutine 7 [chan receive]: I0115 15:19:48.683] github.com/golang/glog.(*loggingT).flushDaemon(0x3363e60) I0115 15:19:48.683] /go/pkg/mod/github.com/golang/glog@v0.0.0-20160126235308-23def4e6c14b/glog.go:882 +0xae I0115 15:19:48.683] created by github.com/golang/glog.init.0 I0115 15:19:48.683] /go/pkg/mod/github.com/golang/glog@v0.0.0-20160126235308-23def4e6c14b/glog.go:410 +0x31b I0115 15:19:48.683] I0115 15:19:48.683] goroutine 34 [select]: I0115 15:19:48.684] go.opencensus.io/stats/view.(*worker).start(0xc0005ca000) I0115 15:19:48.684] /go/pkg/mod/go.opencensus.io@v0.22.1/stats/view/worker.go:154 +0x1d6 I0115 15:19:48.684] created by go.opencensus.io/stats/view.init.0 I0115 15:19:48.684] /go/pkg/mod/go.opencensus.io@v0.22.1/stats/view/worker.go:32 +0x9a I0115 15:19:48.684] I0115 15:19:48.684] goroutine 36 [syscall, 10 minutes]: I0115 15:19:48.685] os/signal.signal_recv(0x48a641) I0115 15:19:48.685] /usr/local/go/src/runtime/sigqueue.go:147 +0x9c I0115 15:19:48.685] os/signal.loop() I0115 15:19:48.685] /usr/local/go/src/os/signal/signal_unix.go:23 +0x30 I0115 15:19:48.685] created by os/signal.init.0 I0115 15:19:48.685] /usr/local/go/src/os/signal/signal_unix.go:29 +0x4f I0115 15:19:48.685] I0115 15:19:48.686] goroutine 102 [syscall, 9 minutes]: I0115 15:19:48.686] syscall.Syscall(0x0, 0x9, 0xc00081c000, 0x1000, 0x0, 0x436062, 0xc000658dd0) I0115 15:19:48.686] /usr/local/go/src/syscall/asm_linux_amd64.s:18 +0x5 I0115 15:19:48.686] syscall.read(0x9, 0xc00081c000, 0x1000, 0x1000, 0x7f70d0a3e5e0, 0x72, 0x0) I0115 15:19:48.686] /usr/local/go/src/syscall/zsyscall_linux_amd64.go:732 +0x68 I0115 15:19:48.686] syscall.Read(0x9, 0xc00081c000, 0x1000, 0x1000, 0x0, 0x1cc7c, 0x7f70dd4793e0) I0115 15:19:48.687] /usr/local/go/src/syscall/syscall_unix.go:183 +0x5b I0115 15:19:48.687] internal/poll.(*FD).Read(0xc00074e360, 0xc00081c000, 0x1000, 0x1000, 0x0, 0x0, 0x0) I0115 15:19:48.687] /usr/local/go/src/internal/poll/fd_unix.go:165 +0x1c8 I0115 15:19:48.687] os.(*File).read(...) I0115 15:19:48.687] /usr/local/go/src/os/file_unix.go:259 I0115 15:19:48.687] os.(*File).Read(0xc0006ca2e8, 0xc00081c000, 0x1000, 0x1000, 0x6, 0x48c1fc, 0x4d0309) I0115 15:19:48.687] /usr/local/go/src/os/file.go:116 +0xa7 I0115 15:19:48.688] github.com/AlecAivazis/survey/v2/terminal.(*BufferedReader).Read(0xc0008185a0, 0xc00081c000, 0x1000, 0x1000, 0xc00074e360, 0xc00081a0a0, 0x6) I0115 15:19:48.688] /go/pkg/mod/github.com/!alec!aivazis/survey/v2@v2.0.4/terminal/buffered_reader.go:21 +0x1dd I0115 15:19:48.688] bufio.(*Reader).fill(0xc000672f60) I0115 15:19:48.688] /usr/local/go/src/bufio/bufio.go:100 +0x19a I0115 15:19:48.688] bufio.(*Reader).ReadRune(0xc000672f60, 0xc0006591d0, 0x54aaa6, 0x33490e0, 0x21c8740) I0115 15:19:48.688] /usr/local/go/src/bufio/bufio.go:287 +0x4b I0115 15:19:48.689] github.com/AlecAivazis/survey/v2/terminal.(*RuneReader).ReadRune(0xc00061d560, 0xc0006ca2e8, 0xc0006593e8, 0x1, 0x1) I0115 15:19:48.689] /go/pkg/mod/github.com/!alec!aivazis/survey/v2@v2.0.4/terminal/runereader_posix.go:64 +0x74 I0115 15:19:48.689] github.com/AlecAivazis/survey/v2.(*Select).Prompt(0xc000757860, 0xc000759908, 0x0, 0x0, 0x0, 0x0) I0115 15:19:48.689] /go/pkg/mod/github.com/!alec!aivazis/survey/v2@v2.0.4/select.go:263 +0x644 I0115 15:19:48.689] github.com/AlecAivazis/survey/v2.Ask(0xc0006597c0, 0x1, 0x1, 0x1f0b280, 0xc0004f40f0, 0xc0006597c8, 0x1, 0x1, 0x0, 0x0) I0115 15:19:48.690] /go/pkg/mod/github.com/!alec!aivazis/survey/v2@v2.0.4/survey.go:278 +0x7cb I0115 15:19:48.690] github.com/tektoncd/cli/pkg/helper/options.(*LogOptions).Ask(0xc000659e90, 0x22132fa, 0xb, 0xc0006c21a0, 0x2, 0x2, 0xc00069e330, 0x23) I0115 15:19:48.690] /go/src/github.com/tektoncd/cli/pkg/helper/options/logs.go:83 +0x36e I0115 15:19:48.690] github.com/tektoncd/cli/pkg/cmd/pipeline.askRunName(0xc000659e90, 0xf, 0xc0004f4070) I0115 15:19:48.690] /go/src/github.com/tektoncd/cli/pkg/cmd/pipeline/logs.go:192 +0x3c9 I0115 15:19:48.690] github.com/tektoncd/cli/pkg/cmd/pipeline.getAllInputs(0xc000659e90, 0xc00074e660, 0x0) I0115 15:19:48.691] /go/src/github.com/tektoncd/cli/pkg/cmd/pipeline/logs.go:161 +0x1a1 I0115 15:19:48.691] github.com/tektoncd/cli/pkg/cmd/pipeline.initOpts(0xc0006dce90, 0x33817a8, 0x0, 0x0, 0xc0006dcbf0, 0x433525) I0115 15:19:48.691] /go/src/github.com/tektoncd/cli/pkg/cmd/pipeline/logs.go:124 +0x2c9 I0115 15:19:48.691] github.com/tektoncd/cli/pkg/cmd/pipeline.run(0xc000659e90, 0x33817a8, 0x0, 0x0, 0xc0006ca2e8, 0xc0006ca2e8) I0115 15:19:48.691] /go/src/github.com/tektoncd/cli/pkg/cmd/pipeline/logs.go:105 +0x5b I0115 15:19:48.692] github.com/tektoncd/cli/pkg/cmd/pipeline.TestPipelineLog_Interactive.func8.1(0x25c7860, 0xc0006ca2e8, 0x25c78a0, 0xc0006ca2e8, 0x25b3fc0, 0xc0006ca2e8, 0x0, 0x6d) I0115 15:19:48.692] /go/src/github.com/tektoncd/cli/pkg/cmd/pipeline/logs_test.go:566 +0x23a I0115 15:19:48.692] github.com/tektoncd/cli/test/prompt.(*Prompt).RunTest(0xc00074e1c0, 0xc0006f9e00, 0x22b26d0, 0xc0006dce00) I0115 15:19:48.692] /go/src/github.com/tektoncd/cli/test/prompt/prompt.go:51 +0x324 I0115 15:19:48.692] github.com/tektoncd/cli/pkg/cmd/pipeline.TestPipelineLog_Interactive.func8(0xc0006f9e00) I0115 15:19:48.693] /go/src/github.com/tektoncd/cli/pkg/cmd/pipeline/logs_test.go:562 +0x2ef I0115 15:19:48.693] testing.tRunner(0xc0006f9e00, 0xc000435f60) I0115 15:19:48.693] /usr/local/go/src/testing/testing.go:909 +0x19a I0115 15:19:48.693] created by testing.(*T).Run I0115 15:19:48.693] /usr/local/go/src/testing/testing.go:960 +0x652 I0115 15:19:48.693] I0115 15:19:48.693] goroutine 101 [chan receive, 9 minutes]: I0115 15:19:48.694] testing.(*T).Run(0xc0006f9d00, 0x2262879, 0x3e, 0xc000435f60, 0xc000543720) I0115 15:19:48.694] /usr/local/go/src/testing/testing.go:961 +0x68a I0115 15:19:48.694] github.com/tektoncd/cli/pkg/cmd/pipeline.TestPipelineLog_Interactive(0xc0006f9d00) I0115 15:19:48.694] /go/src/github.com/tektoncd/cli/pkg/cmd/pipeline/logs_test.go:548 +0x1ef8 I0115 15:19:48.694] testing.tRunner(0xc0006f9d00, 0x22b2708) I0115 15:19:48.694] /usr/local/go/src/testing/testing.go:909 +0x19a I0115 15:19:48.695] created by testing.(*T).Run I0115 15:19:48.695] /usr/local/go/src/testing/testing.go:960 +0x652 I0115 15:19:48.695] I0115 15:19:48.695] goroutine 103 [syscall, 9 minutes]: I0115 15:19:48.695] syscall.Syscall(0x0, 0x8, 0xc0007f6000, 0x8000, 0x6, 0x48c1fc, 0x4d0309) I0115 15:19:48.695] /usr/local/go/src/syscall/asm_linux_amd64.s:18 +0x5 I0115 15:19:48.695] syscall.read(0x8, 0xc0007f6000, 0x8000, 0x8000, 0x7f70d0a3e6b0, 0x72, 0x0) I0115 15:19:48.696] /usr/local/go/src/syscall/zsyscall_linux_amd64.go:732 +0x68 I0115 15:19:48.696] syscall.Read(0x8, 0xc0007f6000, 0x8000, 0x8000, 0x0, 0x0, 0x0) I0115 15:19:48.696] /usr/local/go/src/syscall/syscall_unix.go:183 +0x5b I0115 15:19:48.696] internal/poll.(*FD).Read(0xc00074e300, 0xc0007f6000, 0x8000, 0x8000, 0x0, 0x0, 0x0) I0115 15:19:48.696] /usr/local/go/src/internal/poll/fd_unix.go:165 +0x1c8 I0115 15:19:48.696] os.(*File).read(...) I0115 15:19:48.696] /usr/local/go/src/os/file_unix.go:259 I0115 15:19:48.697] os.(*File).Read(0xc0006ca2e0, 0xc0007f6000, 0x8000, 0x8000, 0x6, 0x0, 0x0) I0115 15:19:48.697] /usr/local/go/src/os/file.go:116 +0xa7 I0115 15:19:48.697] io.copyBuffer(0x25b3fc0, 0xc0006ca2f8, 0x25b3fa0, 0xc0006ca2e0, 0xc0007f6000, 0x8000, 0x8000, 0xc0005c21e0, 0xc0005c2960, 0xc0000617c0) I0115 15:19:48.697] /usr/local/go/src/io/io.go:402 +0x144 I0115 15:19:48.697] io.Copy(...) I0115 15:19:48.697] /usr/local/go/src/io/io.go:364 I0115 15:19:48.698] github.com/Netflix/go-expect.NewPassthroughPipe.func1(0xc00074e540, 0xc0006ca2f8, 0x25b3fa0, 0xc0006ca2e0, 0xc0004f4010) I0115 15:19:48.698] /go/pkg/mod/github.com/!netflix/go-expect@v0.0.0-20190729225929-0e00d9168667/passthrough_pipe.go:42 +0xce I0115 15:19:48.698] created by github.com/Netflix/go-expect.NewPassthroughPipe I0115 15:19:48.698] /go/pkg/mod/github.com/!netflix/go-expect@v0.0.0-20190729225929-0e00d9168667/passthrough_pipe.go:40 +0x12a I0115 15:19:48.698] I0115 15:19:48.698] goroutine 104 [syscall, 9 minutes]: I0115 15:19:48.699] syscall.Syscall(0x0, 0x6, 0xc0007ee000, 0x8000, 0x1000, 0x1000, 0x7f70dac82b00) I0115 15:19:48.699] /usr/local/go/src/syscall/asm_linux_amd64.s:18 +0x5 I0115 15:19:48.699] syscall.read(0x6, 0xc0007ee000, 0x8000, 0x8000, 0x7f70d0a3e850, 0x72, 0x0) I0115 15:19:48.699] /usr/local/go/src/syscall/zsyscall_linux_amd64.go:732 +0x68 I0115 15:19:48.699] syscall.Read(0x6, 0xc0007ee000, 0x8000, 0x8000, 0x0, 0x336d2d8, 0x7f70d0a3f530) I0115 15:19:48.699] /usr/local/go/src/syscall/syscall_unix.go:183 +0x5b I0115 15:19:48.700] internal/poll.(*FD).Read(0xc00074e1e0, 0xc0007ee000, 0x8000, 0x8000, 0x0, 0x0, 0x0) I0115 15:19:48.700] /usr/local/go/src/internal/poll/fd_unix.go:165 +0x1c8 I0115 15:19:48.700] os.(*File).read(...) I0115 15:19:48.700] /usr/local/go/src/os/file_unix.go:259 I0115 15:19:48.700] os.(*File).Read(0xc0006ca2d0, 0xc0007ee000, 0x8000, 0x8000, 0x0, 0x0, 0x0) I0115 15:19:48.700] /usr/local/go/src/os/file.go:116 +0xa7 I0115 15:19:48.701] io.copyBuffer(0x25b1520, 0xc00071c240, 0x25b3fa0, 0xc0006ca2d0, 0xc0007ee000, 0x8000, 0x8000, 0x590b9e, 0x22b42a0, 0x0) I0115 15:19:48.701] /usr/local/go/src/io/io.go:402 +0x144 I0115 15:19:48.701] io.Copy(...) I0115 15:19:48.701] /usr/local/go/src/io/io.go:364 I0115 15:19:48.701] github.com/Netflix/go-expect.NewConsole.func1(0xc00071c240, 0x25b3fa0, 0xc0006ca2d0) I0115 15:19:48.701] /go/pkg/mod/github.com/!netflix/go-expect@v0.0.0-20190729225929-0e00d9168667/console.go:171 +0x78 I0115 15:19:48.701] created by github.com/Netflix/go-expect.NewConsole I0115 15:19:48.702] /go/pkg/mod/github.com/!netflix/go-expect@v0.0.0-20190729225929-0e00d9168667/console.go:170 +0x72c I0115 15:19:48.702] I0115 15:19:48.702] goroutine 105 [IO wait, 9 minutes]: I0115 15:19:48.702] internal/poll.runtime_pollWait(0x7f70d0a3e510, 0x72, 0x25b5720) I0115 15:19:48.702] /usr/local/go/src/runtime/netpoll.go:184 +0x55 I0115 15:19:48.702] internal/poll.(*pollDesc).wait(0xc00074e438, 0x72, 0x1, 0x10, 0xffffffffffffffff) I0115 15:19:48.703] /usr/local/go/src/internal/poll/fd_poll_runtime.go:87 +0xe4 I0115 15:19:48.703] internal/poll.(*pollDesc).waitRead(...) I0115 15:19:48.703] /usr/local/go/src/internal/poll/fd_poll_runtime.go:92 I0115 15:19:48.703] internal/poll.(*FD).Read(0xc00074e420, 0xc000458f60, 0x10, 0x10, 0x0, 0x0, 0x0) I0115 15:19:48.703] /usr/local/go/src/internal/poll/fd_unix.go:169 +0x253 I0115 15:19:48.703] os.(*File).read(...) I0115 15:19:48.703] /usr/local/go/src/os/file_unix.go:259 I0115 15:19:48.704] os.(*File).Read(0xc0006ca2f0, 0xc000458f60, 0x10, 0x10, 0x0, 0xc00031c4d0, 0xb0) I0115 15:19:48.704] /usr/local/go/src/os/file.go:116 +0xa7 I0115 15:19:48.704] github.com/Netflix/go-expect.(*PassthroughPipe).Read(0xc0004f4030, 0xc000458f60, 0x10, 0x10, 0x0, 0x1, 0x1) I0115 15:19:48.704] /go/pkg/mod/github.com/!netflix/go-expect@v0.0.0-20190729225929-0e00d9168667/passthrough_pipe.go:70 +0x85 I0115 15:19:48.704] bufio.(*Reader).fill(0xc00074e600) I0115 15:19:48.704] /usr/local/go/src/bufio/bufio.go:100 +0x19a I0115 15:19:48.705] bufio.(*Reader).ReadRune(0xc00074e600, 0x1, 0x1, 0x0, 0x21c6760) I0115 15:19:48.705] /usr/local/go/src/bufio/bufio.go:287 +0x4b I0115 15:19:48.705] github.com/Netflix/go-expect.(*Console).Expect(0xc00071c240, 0xc000466df0, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0) I0115 15:19:48.705] /go/pkg/mod/github.com/!netflix/go-expect@v0.0.0-20190729225929-0e00d9168667/expect.go:89 +0x3bc I0115 15:19:48.705] github.com/Netflix/go-expect.(*Console).ExpectString(0xc00071c240, 0x2218f52, 0x10, 0x0, 0x0, 0x0, 0x0) I0115 15:19:48.706] /go/pkg/mod/github.com/!netflix/go-expect@v0.0.0-20190729225929-0e00d9168667/expect.go:35 +0xd6 I0115 15:19:48.706] github.com/tektoncd/cli/pkg/cmd/pipeline.TestPipelineLog_Interactive.func1(0xc00071c240, 0x0, 0x0) I0115 15:19:48.706] /go/src/github.com/tektoncd/cli/pkg/cmd/pipeline/logs_test.go:323 +0x66 I0115 15:19:48.706] github.com/tektoncd/cli/test/prompt.(*Prompt).RunTest.func1(0xc0006c0cc0, 0x22b26d0, 0xc00071c240, 0xc0006f9e00) I0115 15:19:48.706] /go/src/github.com/tektoncd/cli/test/prompt/prompt.go:46 +0x90 I0115 15:19:48.706] created by github.com/tektoncd/cli/test/prompt.(*Prompt).RunTest I0115 15:19:48.707] /go/src/github.com/tektoncd/cli/test/prompt/prompt.go:44 +0x200 I0115 15:19:48.707] FAIL github.com/tektoncd/cli/pkg/cmd/pipeline 600.205s ==

tekton-robot · 2020-01-15T18:29:39Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/logs.go	86.3%	84.0%	-2.3

chmouel · 2020-01-15T18:36:56Z

so disabling the problematic flakey made it green :(

https://github.com/tektoncd/cli/pull/563/files#diff-7912121959026858cece65825f4a1e5cR221

I am still not understanding everything, why is it that the flakeyness appears only on that test and only now and not othe reviews?

is there something we do in the tests (ie closing the vt) that we are not doing properly and expose that crash ?

vdemeester

/lgtm

tekton-robot · 2020-01-16T08:35:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot requested review from danielhelfand and vdemeester January 1, 2020 14:19

googlebot added the cla: yes label Jan 1, 2020

tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 1, 2020

chmouel force-pushed the fix-pipeline-log-with-only-one branch from 8e56d8c to 00cbffb Compare January 1, 2020 14:31

vdemeester approved these changes Jan 2, 2020

View reviewed changes

tekton-robot assigned vdemeester Jan 2, 2020

tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 2, 2020

piyush-garg reviewed Jan 6, 2020

View reviewed changes

chmouel force-pushed the fix-pipeline-log-with-only-one branch from 00cbffb to b5b9c72 Compare January 6, 2020 18:08

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2020

chmouel force-pushed the fix-pipeline-log-with-only-one branch from b5b9c72 to 4abff9c Compare January 15, 2020 06:44

chmouel force-pushed the fix-pipeline-log-with-only-one branch from 4abff9c to 5389855 Compare January 15, 2020 10:19

vdemeester approved these changes Jan 15, 2020

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020

vdemeester approved these changes Jan 16, 2020

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2020

tekton-robot merged commit 9196305 into tektoncd:master Jan 16, 2020

chmouel deleted the fix-pipeline-log-with-only-one branch June 27, 2021 05:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix to auto select the first pipeline when only one is available #563

Fix to auto select the first pipeline when only one is available #563

chmouel commented Jan 1, 2020

chmouel commented Jan 1, 2020 via email

chmouel commented Jan 1, 2020

piyush-garg commented Jan 2, 2020

vdemeester left a comment

vdemeester commented Jan 2, 2020

piyush-garg Jan 6, 2020

chmouel Jan 15, 2020 •

edited

Loading

chmouel commented Jan 6, 2020

chmouel commented Jan 15, 2020

vdemeester left a comment

chmouel commented Jan 15, 2020

chmouel commented Jan 15, 2020

chmouel commented Jan 15, 2020

chmouel commented Jan 15, 2020

chmouel commented Jan 15, 2020

vdemeester commented Jan 15, 2020

tekton-robot commented Jan 15, 2020

chmouel commented Jan 15, 2020 •

edited

Loading

vdemeester left a comment

tekton-robot commented Jan 16, 2020

Fix to auto select the first pipeline when only one is available #563

Fix to auto select the first pipeline when only one is available #563

Conversation

chmouel commented Jan 1, 2020

Changes

Submitter Checklist

Release Notes

chmouel commented Jan 1, 2020 via email

chmouel commented Jan 1, 2020

piyush-garg commented Jan 2, 2020

vdemeester left a comment

Choose a reason for hiding this comment

vdemeester commented Jan 2, 2020

piyush-garg Jan 6, 2020

Choose a reason for hiding this comment

chmouel Jan 15, 2020 • edited Loading

Choose a reason for hiding this comment

chmouel commented Jan 6, 2020

chmouel commented Jan 15, 2020

vdemeester left a comment

Choose a reason for hiding this comment

chmouel commented Jan 15, 2020

chmouel commented Jan 15, 2020

chmouel commented Jan 15, 2020

chmouel commented Jan 15, 2020

chmouel commented Jan 15, 2020

vdemeester commented Jan 15, 2020

tekton-robot commented Jan 15, 2020

chmouel commented Jan 15, 2020 • edited Loading

vdemeester left a comment

Choose a reason for hiding this comment

tekton-robot commented Jan 16, 2020

chmouel Jan 15, 2020 •

edited

Loading

chmouel commented Jan 15, 2020 •

edited

Loading