-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove repeated sentence. #636
Conversation
Hi @ansky. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great suggestion, and thanks for pointing this out. I have included individual line feedback below, but here is what I think would work here if you are willing to add some additional edits. WDYT?
kubectl
will find any binary named kubectl-*
on your PATH and consider it as a plugin.
After installing tkn, create a link as kubectl-tkn:
$ ln -s /usr/local/bin/tkn /usr/local/bin/kubectl-tkn
Run the following to confirm tkn is available as a plugin:
$ kubectl plugin list
You should see the following after running kubectl plugin list
if tkn
is available as a plugin:
/usr/local/bin/kubectl-tkn
If the output above is shown, run kubectl-tkn
to see the list of available tkn
commands to run.
|
||
`kubectl` will find any binary named `kubectl-*` on your `PATH` and consider it as a plugin | ||
|
||
Run the following to confirm tkn is available as a plugin: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't thank this is needed isnt it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not technically needed, but I think it makes sense as a way to confirm it's available before running kubectl-tkn
. Better to know it's set up correctly before running commands with it.
/ok-to-test |
|
||
`kubectl` will find any binary named `kubectl-*` on your `PATH` and consider it as a plugin | ||
|
||
Run the following to confirm tkn is available as a plugin: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run the following to confirm tkn is available as a plugin: | |
Run the following to confirm `tkn` is available as a plugin: |
```shell | ||
/usr/local/bin/kubectl-tkn | ||
``` | ||
If the output above is shown, run kubectl-tkn to see the list of available tkn commands to run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the output above is shown, run kubectl-tkn to see the list of available tkn commands to run. | |
If the output above is shown, run `kubectl-tkn` to see the list of available `tkn` commands to run. |
@ansky Can you please squash the commits into one |
I am fine with this change but please do the squashing as the git history will look more clearer for us.. here there is an article about it https://github.blog/2016-04-01-squash-your-commits/ we cannot do it oursevles on merge since we are using prow as the tool to merge our commit (which doesnt support squashing) |
/hold Let's wait until commits are squashed |
Commits have been squashed. |
/hold cancel Thanks 👍🏼🔥 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, danielhelfand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ansky Thanks so much! |
Changes
Remove repeated sentence. Minor fix to documentation only.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make docs
andmake man
if needed.make check
See the contribution guide
for more details.
Release Notes