Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repeated sentence. #636

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Remove repeated sentence. #636

merged 1 commit into from
Jan 31, 2020

Conversation

ansky
Copy link
Contributor

@ansky ansky commented Jan 24, 2020

Changes

Remove repeated sentence. Minor fix to documentation only.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

@tekton-robot
Copy link
Contributor

Hi @ansky. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 24, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2020
Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion, and thanks for pointing this out. I have included individual line feedback below, but here is what I think would work here if you are willing to add some additional edits. WDYT?

kubectl will find any binary named kubectl-* on your PATH and consider it as a plugin.
After installing tkn, create a link as kubectl-tkn:

$ ln -s /usr/local/bin/tkn /usr/local/bin/kubectl-tkn

Run the following to confirm tkn is available as a plugin:

$ kubectl plugin list

You should see the following after running kubectl plugin list if tkn is available as a plugin:

/usr/local/bin/kubectl-tkn

If the output above is shown, run kubectl-tkn to see the list of available tkn commands to run.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2020

`kubectl` will find any binary named `kubectl-*` on your `PATH` and consider it as a plugin

Run the following to confirm tkn is available as a plugin:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't thank this is needed isnt it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not technically needed, but I think it makes sense as a way to confirm it's available before running kubectl-tkn. Better to know it's set up correctly before running commands with it.

@chmouel
Copy link
Member

chmouel commented Jan 26, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2020

`kubectl` will find any binary named `kubectl-*` on your `PATH` and consider it as a plugin

Run the following to confirm tkn is available as a plugin:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Run the following to confirm tkn is available as a plugin:
Run the following to confirm `tkn` is available as a plugin:

```shell
/usr/local/bin/kubectl-tkn
```
If the output above is shown, run kubectl-tkn to see the list of available tkn commands to run.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If the output above is shown, run kubectl-tkn to see the list of available tkn commands to run.
If the output above is shown, run `kubectl-tkn` to see the list of available `tkn` commands to run.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@piyush-garg
Copy link
Contributor

@ansky Can you please squash the commits into one

@chmouel
Copy link
Member

chmouel commented Jan 30, 2020

I am fine with this change but please do the squashing as the git history will look more clearer for us.. here there is an article about it https://github.blog/2016-04-01-squash-your-commits/ we cannot do it oursevles on merge since we are using prow as the tool to merge our commit (which doesnt support squashing)

@danielhelfand
Copy link
Member

/hold

Let's wait until commits are squashed

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2020
@ansky
Copy link
Contributor Author

ansky commented Jan 31, 2020

Commits have been squashed.

@chmouel
Copy link
Member

chmouel commented Jan 31, 2020

/hold cancel
/lgtm
/approve

Thanks 👍🏼🔥

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, danielhelfand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chmouel,danielhelfand]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danielhelfand
Copy link
Member

@ansky Thanks so much!

@tekton-robot tekton-robot merged commit d381476 into tektoncd:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants