Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dry-run Option for tkn ct start #663

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Add --dry-run Option for tkn ct start #663

merged 1 commit into from
Feb 3, 2020

Conversation

danielhelfand
Copy link
Member

Closes #659

Similar to #662 and #643, this pull request adds the ability to do a dry run of a taskrun with tkn clustertask start. A notable issue with this, is that steps won't be included with this approach since it mainly relies on a TaskRef to start clustertasks, but it does show information on inputs, outputs, and params as well as the task reference being used.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

Release Notes

Add --dry-run option to tkn clustertask start

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 30, 2020
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
@pradeepitm12
Copy link
Contributor

/lgtm

@chmouel chmouel closed this Feb 3, 2020
@chmouel chmouel reopened this Feb 3, 2020
@chmouel
Copy link
Member

chmouel commented Feb 3, 2020

/lgtm
/approve

Thanks 👍🏼🔥

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@tekton-robot tekton-robot merged commit 45c4565 into tektoncd:master Feb 3, 2020
@danielhelfand danielhelfand deleted the ct_dry_run branch February 10, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --dry-run Option for tkn clustertask start
6 participants