--all option for tkn taskrun delete #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
danielhelfand
commented
Feb 4, 2020
| @@ -28,24 +28,31 @@ type DeleteOptions struct { | |||
| ParentResource string | |||
| ParentResourceName string | |||
| ForceDelete bool | |||
| DeleteAll bool | |||
| DeleteRelated bool | |||
There was a problem hiding this comment.
I renamed this as it more focuses on deleting related resources.
danielhelfand
commented
Feb 4, 2020
| @@ -28,24 +28,31 @@ type DeleteOptions struct { | |||
| ParentResource string | |||
| ParentResourceName string | |||
| ForceDelete bool | |||
| DeleteAll bool | |||
| DeleteRelated bool | |||
| DeleteAllNs bool | |||
There was a problem hiding this comment.
DeleteAllNs since there will be ClusterTask case where it's not focused on deleting all resources in a namespace. We should eventually have another option for cluster scope resources.
danielhelfand
commented
Feb 4, 2020
| d.PrintSuccesses(s) | ||
| } else { | ||
| if d.Errors() == nil { | ||
| fmt.Fprintf(s.Out, "All TaskRuns deleted in namespace %q\n", p.Namespace()) |
There was a problem hiding this comment.
Print message saying all taskruns were deleted instead of showing every taskrun name that was deleted. Only displays if no errors.
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
looks good to me /lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
5 tasks
vdemeester
added a commit
that referenced
this pull request
Feb 28, 2020
#674 | [Piyush Garg] Update readme for 0.7.1 release | 2020/02/04-09:25 #678 | [Vincent Demeester] Bump gotest.tools/v3 dep to 3.0.1 | 2020/02/05-02:08 #609 | [Chmouel Boudjnah] Start doing testing against nightly | 2020/02/05-09:50 #676 | [Daniel Helfand] --all option for tkn taskrun delete | 2020/02/05-12:10 #682 | [Chmouel Boudjnah] Add flag --use-pipelinerun to start to rerun with a target pr | 2020/02/06-03:07 #677 | [Piyush Garg] Improve release docs | 2020/02/06-08:25 #681 | [Chmouel Boudjnah] Add --output by name for TaskRuns | 2020/02/10-02:32 #681 | [Chmouel Boudjnah] Add --output by name for TriggerBinding | 2020/02/10-02:32 #692 | [Daniel Helfand] add tkn cluster delete --all | 2020/02/10-04:22 #694 | [Piyush Garg] Add --step flag for taskrun logs | 2020/02/10-09:30 null | [Daniel Helfand] --all option for tkn el delete | 2020/02/10-15:01 null | [Daniel Helfand] --all option for tkn resource delete | 2020/02/10-15:24 null | [Daniel Helfand] -all option for tkn condition delete | 2020/02/10-15:25 null | [16yuki0702] Fix bug about Complete logs not shown for failed TaskRun related issue is #587 | 2020/02/10-15:38 null | [Daniel Helfand] --all option for tkn pipelinerun delete | 2020/02/10-16:37 null | [Chmouel Boudjnah] Shows --- for empty values on "DEFAULT VALUES" column | 2020/02/11-02:38 null | [Chmouel Boudjnah] Makefile fixes | 2020/02/11-05:20 null | [Chmouel Boudjnah] Update github pull request templates | 2020/02/11-05:20 null | [Chmouel Boudjnah] Add pipeline version information | 2020/02/12-01:36 null | [Daniel Helfand] --all option for tkn triggertemplate delete | 2020/02/12-01:49 null | [Chmouel Boudjnah] Fix help command | 2020/02/12-03:22 null | [Chmouel Boudjnah] Fix yaml errors | 2020/02/12-08:00 null | [Chmouel Boudjnah] Update presubmit jobs to use make lint | 2020/02/12-08:00 null | [Chmouel Boudjnah] Add support for filtering by label on pipelinerun | 2020/02/12-08:19 null | [Chmouel Boudjnah] Add support for filtering by label on taskruns | 2020/02/12-08:19 null | [Daniel Helfand] --all option for tkn triggerbinding delete | 2020/02/12-16:03 null | [Chmouel Boudjnah] Add --last support to `tkn pr logs` | 2020/02/13-01:51 null | [Daniel Helfand] nil check for lr.Stream for taskrun logs | 2020/02/13-02:08 null | [Pradeep Kumar] Fix typo | 2020/02/14-06:44 null | [Chmouel Boudjnah] Modify test names as they are pipelinerun not pipeline tests | 2020/02/14-12:30 null | [Chmouel Boudjnah] Add --last flag to tkn taskrun logs | 2020/02/14-12:30 null | [Daniel Helfand] --prefix-name option for tkn pipeline start | 2020/02/17-03:32 null | [Daniel Helfand] add warning for --all flags for pipeline and task delete | 2020/02/17-03:33 null | [Vincent Demeester] Update golangci-lint target 🍵 | 2020/02/18-03:38 null | [Chmouel Boudjnah] Generate manpages at the same time as make docs | 2020/02/18-04:42 null | [Chmouel Boudjnah] Make sure golden files have been generated | 2020/02/18-04:42 null | [Pradeep Kumar] Adds timeout to pipeline start | 2020/02/18-07:50 null | [Chmouel Boudjnah] Add fuzzyfinder library | 2020/02/18-09:08 null | [Chmouel Boudjnah] Add fuzzy finder selection for pipelinerun and taskrun | 2020/02/18-09:08 null | [Chmouel Boudjnah] Increase default limit when using with fzf | 2020/02/18-09:08 null | [16yuki0702] Refactoring log writer. related issue is #708 | 2020/02/19-02:24 null | [Vincent Demeester] Use -mod=vendor for golangci-lint too 👼 | 2020/02/19-03:36 null | [Vincent Demeester] Fix linting on pkg/log 🚈 | 2020/02/19-03:36 null | [Chmouel Boudjnah] Add --use-taskrun for taskrun | 2020/02/19-07:26 null | [Daniel Helfand] show sidecar names with tkn tr desc | 2020/02/24-06:08 null | [Daniel Helfand] add warning message for tkn task start --timeout | 2020/02/26-02:18 null | [16yuki0702] Refactoring log reader. related issue is #748 | 2020/02/26-08:14 null | [Daniel Helfand] --prefix-name option for tkn task start | 2020/02/27-02:03 null | [Daniel Helfand] add error message for deletion when args=0 and no --all flag | 2020/02/27-02:15 null | [Vincent Demeester] Remove trigger alias for start subcommands 🚉 | 2020/02/27-07:37 null | [Chmouel Boudjnah] Add --keep to --all, to keep the last N pipelineruns | 2020/02/27-09:32 null | [Vincent Demeester] Add --keep to --all, to keep the last N taskruns | 2020/02/27-09:32 null | [Vincent Demeester] Enhance the error message for --keep ⌨ | 2020/02/27-09:32 null | [Vincent Demeester] Pin the go version in the release pipeline 🖊 | 2020/02/27-11:03 null | [Vincent Demeester] Use -mod=vendor during the release 👼 | 2020/02/27-11:59 Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #634
This pull request adds an
--alloption totkn taskrun deletethat will delete all taskruns that exist in a namespace. It follows the pattern we use for all delete commands by prompting the user if he or she would like to delete the resource. There is also the-foption to force a delete without a prompt.Delete all taskruns in namespace ns:
There will be a slight issue implementing this
--allapproach for Pipeline/Task: the--allflag is already in use, but I think we should change those to--relatedas it focuses on deleting related pipelineruns/taskruns.Changes
make docsandmake manif needed.make checkRelease Notes