Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error Message for Deletion When No Args or --all Flag Specified #745

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Add Error Message for Deletion When No Args or --all Flag Specified #745

merged 1 commit into from
Feb 27, 2020

Conversation

danielhelfand
Copy link
Member

@danielhelfand danielhelfand commented Feb 18, 2020

Since deletion commands, with the exception of Pipeline and Task, don't require an arg anymore as part of adding --all, there should be an error message if no args are passed for deletion or the --all flag isn't used.

Currently, if a user runs something like tkn condition delete, the result would be getting a prompt like below:

Are you sure you want to delete condition  (y/n):

While this is harmless as far as deleting resources, it's not great presentation. This error message would result in the following change:

Error: must provide condition name(s) or use --all flag with delete

Submitter Checklist

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

Improve deletion error message if no args or no --all flag 

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/helper/options/delete.go 95.5% 91.7% -3.8

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/helper/options/delete.go 95.5% 95.8% 0.4

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/helper/options/delete.go 95.5% 95.8% 0.4

@danielhelfand danielhelfand added this to the 0.8.0 🐯 milestone Feb 19, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2020
@tekton-robot tekton-robot merged commit 1ed211c into tektoncd:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants