[TEP-0050] Simplify continueAndFail to continue #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the proposal 2 valid values for `PipelineTask` `OnError` field: `continueAndFail` and `StopAndFail`. `continueAndFail` indicates to fail the `PipelineTask`, continue to execute the DAG, and DO NOT fail the `PipelineRun`. However, the name `continueAndFail` is very confusing since - 'continue' and 'Fail' sounds like a conflict (see [comment](tektoncd#785 (comment))) - 'Fail' could be intepreted as failing the whole `pipelinerun`, which is not the expected behavior This commit simplifies the value to `continue`. This is more straightforward and more consistent with `step.OnError`. /kind tep
tekton-robot
added
the
kind/tep
tekton-robot
added
the
size/M
|
Makes sense to me. |
tekton-robot
added
the
approved
pritidesai
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
thanks a bunch @QuanZhang-William for your patience and excited to have this feature 🎉
|
Since its a small change - renaming one of the options - I think we can merge this |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, jerop, pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the proposal 2 valid values for
PipelineTaskOnErrorfield:continueAndFailandStopAndFail.continueAndFailindicates to fail thePipelineTask, continue to execute the DAG, and DO NOT fail thePipelineRun. However, the namecontinueAndFailis very confusing sincecontinueandFailsounds like a conflict (see comment)Failcould be interpreted as failing the wholepipelinerun, which is not the expected behaviorThis commit simplifies the value to
continue. This is more straightforward and more consistent withstep.OnError./kind tep