Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QuanZhang-William to Pipeline Reviewer #1079

Merged

Conversation

QuanZhang-William
Copy link
Member

@QuanZhang-William QuanZhang-William commented Oct 4, 2023

Nominated by @pritidesai, @dibyom, @vdemeester and @afrittoli (Thanks!!)

I started to focus on Tekton Pipeline development since March 2023, and have been involved in several projects:

Here is the list of my PRs:

Here is the list of PRs that I've reviewed:

In-depth knowledge of the specific area demonstrated in Affinity Assistant and the Coschedule PipelineRun Pods feature:

Nominated by @pritidesai, @dibyom, @vdemeester and afrittoli (Thanks!!)

I started to focus on Tekton Pipeline development since March 2023, and have been involved in several projects:

- [TEP-0135: Coschedule PipelineRun Pods](https://github.com/tektoncd/community/blob/main/teps/0135-coscheduling-pipelinerun-pods.md)
- [TEP-0115: Catalog git-based versioning](https://github.com/tektoncd/community/blob/main/teps/0115-tekton-catalog-git-based-versioning.md)
- [TEP-0133: Configure default resolver](https://github.com/tektoncd/community/blob/main/teps/0133-configure-default-resolver.md)

Here is the list of my PRs:
- https://github.com/tektoncd/pipeline/pulls/QuanZhang-William

Here is the list of PRs that I've reviewed:
- https://github.com/tektoncd/pipeline/pulls?q=is%3Aopen+is%3Apr+reviewed-by%3AQuanZhang-William++-author%3AQuanZhang-William

In-depth knowledge of the specific area demonstrated in Affinity Assistant and the Coschedule PipelineRun Pods feature:
- tektoncd/pipeline#6740
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2023
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2023
@chuangw6
Copy link
Member

chuangw6 commented Oct 4, 2023

/lgtm

Welcome aboard! 🎉 Thanks for all your contributions @QuanZhang-William !

@tekton-robot
Copy link
Contributor

@chuangw6: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Welcome aboard! 🎉 Thanks for all your contributions @QuanZhang-William !

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@JeromeJu JeromeJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QuanZhang-William for the contributions!

Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @QuanZhang-William for all the work, very exciting 🎉

@dibyom
Copy link
Member

dibyom commented Oct 5, 2023

Yay! Thanks @QuanZhang-William

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, dibyom, JeromeJu, pritidesai, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afrittoli,dibyom,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dibyom
Copy link
Member

dibyom commented Oct 5, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@tekton-robot tekton-robot merged commit 11bf7dc into tektoncd:main Oct 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants