TEP-0142: Make WorkingDir an Actionable Field #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
needs-rebase
|
/kind tep |
tekton-robot
added
size/M
chitrangpatel
force-pushed
the
step-results-with-step-actions
branch
from
946b572
to
8bc8105
Compare
tekton-robot
added
size/S
|
/assign @vdemeester @afrittoli @wlynch |
7 tasks
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
dibyom
reviewed
Dec 8, 2023
Prior to this, the workingDir was not a part of StepActions since it needed some discussion careful evaluation. After lengthy discussions in [Slack threads](https://tektoncd.slack.com/archives/C063ZA89KBK/p1698764302324749) and multiple meetings, we finally took the approach of making it actionable.
chitrangpatel
force-pushed
the
step-results-with-step-actions
branch
from
8bc8105
to
492b819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, the workingDir was not a part of StepActions since it needed some discussion careful evaluation. After lengthy discussions in Slack threads and multiple meetings, we finally take the approach of making it actionable and a part of
StepActions. The reasons are highlighted in the updated design.