Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0020: Add s390x architecture support #212

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

barthy1
Copy link
Member

@barthy1 barthy1 commented Sep 21, 2020

This TEP proposes the way to add s390x support in Tekton.

The TEP is based on "Add other architectures support" TEP 19
and provides information about specific setup to get access to s390x native hardware.
Sequence diagram with steps to access s390x hardware and run build/e2e tests is also provided.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 21, 2020
@vdemeester vdemeester added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Sep 28, 2020
This TEP proposes the way to add s390x architectures support in Tekton.

Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
@dlorenc
Copy link
Contributor

dlorenc commented Oct 13, 2020

/lgtm for proposed state

@dlorenc
Copy link
Contributor

dlorenc commented Oct 13, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
@ghost
Copy link

ghost commented Oct 19, 2020

This lgtm too, though I think we need someone from a different org/company to give it the second lgtm and get it merged.

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
@tekton-robot tekton-robot merged commit 03566c3 into tektoncd:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants