Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TEP-0080 to implemented #518

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Move TEP-0080 to implemented #518

merged 2 commits into from
Sep 16, 2021

Conversation

mattmoor
Copy link
Member

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2021
@mattmoor mattmoor mentioned this pull request Sep 15, 2021
Merged
@bobcatfish
Copy link
Contributor

Thanks @mattmoor ! There's an "implementation pull requests" section in the TEP template that it might make sense to fill out in this PR as well

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@mattmoor
Copy link
Member Author

There's an "implementation pull requests" section in the TEP

Done

vdemeester
vdemeester approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 0fe439a into tektoncd:main Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@danielhelfand danielhelfand Awaiting requested review from danielhelfand

@nikhil-thomas nikhil-thomas Awaiting requested review from nikhil-thomas

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattmoor @bobcatfish @tekton-robot @vdemeester