Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP-0104]: Task-level resource requests #673

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

lbernick
Copy link
Member

@lbernick lbernick commented Apr 8, 2022

This commit adds TEP-0104, which proposes allowing users to specify Kubernetes
resource requests for an entire Task. Migrated from design doc.

/kind tep

@tekton-robot tekton-robot added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Apr 8, 2022
@lbernick
Copy link
Member Author

lbernick commented Apr 8, 2022

/assign @jerop
/assign @vdemeester

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 8, 2022
@lbernick lbernick force-pushed the resources branch 3 times, most recently from 064ba87 to aa0e735 Compare April 8, 2022 14:30
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2022
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2022
@lbernick
Copy link
Member Author

Design for tektoncd/pipeline#4470

creation-date: '2022-04-08'
last-updated: '2022-04-08'
authors:
- '@lbernick'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolute nit, but based on the doc, should we list @jerop and I as authors as well ? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not a nit! happy to add you, maybe we could also add a "collaborators" field to TEP metadata?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not a nit! happy to add you, maybe we could also add a "collaborators" field to TEP metadata?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 👍🏼 would work, reading TEP-XXX again, I think the idea might to change the authors to collaborators, and have all under the same liste.

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 15, 2022
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2022
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This TEP is one of the first ones using the new design doc based process - looks like there are a couple of things to work out:

  1. I think both @vdemeester and @jerop "approved" this which is why the PR got created. So, I think this should be good to merge. But I think the process could be clearer in where the approval should be documented (the issue, the doc, the PR)

  2. With a more collaborative process, we should probably update the TEP metadata to contain a list of collaborators

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2022
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2022
@abayer
Copy link
Contributor

abayer commented Apr 25, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
This commit adds TEP-0104, which proposes allowing users to specify Kubernetes
resource requests for an entire Task.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
@abayer
Copy link
Contributor

abayer commented Apr 25, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
@tekton-robot tekton-robot merged commit 705d68f into tektoncd:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: UnAssigned
Development

Successfully merging this pull request may close these issues.

6 participants