Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP-0115] Update Artifact Hub Usage #842

Merged

Conversation

QuanZhang-William
Copy link
Member

In tektoncd/hub#667, we have discussed and agreed to migrate to the Artifact Hub from the Tekton Hub. This commit updates the git-based versioning proposal for the Artifact Hub, move the Tekton Hub git-based versioning support to future work, and add Artifact Hub remote resolution support to the Hub Resolver.

/kind tep

@tekton-robot tekton-robot added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Oct 4, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 4, 2022
@QuanZhang-William
Copy link
Member Author

QuanZhang-William commented Oct 4, 2022

/cc @vdemeester @PuneetPunamiya @jerop @abayer . Could you please take a look 🙏 ?

@jerop
Copy link
Member

jerop commented Oct 7, 2022

/assign

@afrittoli
Copy link
Member

/assign @vdemeester

@QuanZhang-William
Copy link
Member Author

Hi @jerop , just updated the resolver field from source to type and removed -hub suffix of the resources as you suggested earlier. Please take a look 😁

@QuanZhang-William QuanZhang-William force-pushed the tep-0115-artifact-hub-migration branch 3 times, most recently from 8534ebc to ed49dd9 Compare October 17, 2022 14:45
@pritidesai
Copy link
Member

API WG - ready for review, please take a look!

@jerop
Copy link
Member

jerop commented Oct 17, 2022

cc @tektoncd/catalog-maintainers

In tektoncd/hub#667, we have discussed and agreed to migrate to the Artifact Hub from the Tekton Hub.
This commit updates the git-based versioning proposal for the Artifact Hub, move the Tekton Hub git-based versioning support to future work,
and add Artifact Hub remote resolution support to the Hub Resolver.
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2022
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @QuanZhang-William!

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerop
Copy link
Member

jerop commented Oct 19, 2022

all assignees have approved so merging TEP update offline

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022
@tekton-robot tekton-robot merged commit 5175917 into tektoncd:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: UnAssigned
Development

Successfully merging this pull request may close these issues.

7 participants