-
Notifications
You must be signed in to change notification settings - Fork 265
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix UI bug for TaskRuns in read-only mode
Batch actions should not be enabled in read-only mode. A bug introduced during recent refactoring meant that the read-only flag wasn't being read correctly in this case causing the checkboxes to appear on the TaskRuns table. This gave the impression that TaskRuns could be deleted, however the action is still blocked in environments where RBAC is enforced as the Dashboard ServiceAccount does not have permissions to delete these resources when deployed in read-only mode. Update the test to prevent a similar regression in future, as well as updating the equivalent test for PipelineRuns in the same manner.
- Loading branch information
1 parent
c7640dc
commit 4ae04a3
Showing
3 changed files
with
14 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters