Add styling for active submenus on rail nav #1855
Conversation
tekton-robot
added
the
size/L
| to={this.getPath(urls.conditions.all())} | ||
| > | ||
| Conditions | ||
| </SideNavMenuItem> | ||
| {this.props.isTriggersInstalled && ( | ||
| <> |
There was a problem hiding this comment.
Due to the way the active item detection works in the Carbon SideNavMenu, the SideNavMenuItems must be direct children of the SideNavMenu component and cannot be nested in a fragment or other component. This also means we cannot use a custom component that renders the SideNavMenuItem to reduce the duplication.
When the main nav is collapsed to its rail presentation, ensure we mark any link / menu with an active nav item as active. This is to help orient users and help guide them to the relevant section in the expanded nav.
AlanGreene
force-pushed
the
collapsible_nav_active_submenu
branch
from
5bf9a03
to
d65ecc3
Compare
| {this.props.isTriggersInstalled && ( | ||
| <SideNavMenuItem | ||
| element={NavLink} | ||
| isActive={ |
There was a problem hiding this comment.
Alot of duplication in these isActive parameters, its not big but if you want to move them to a function that takes the url. Ill leave it up to you, how it is is fine too
There was a problem hiding this comment.
Yeah I thought about that when I discovered the nesting issue but figured it didn't really bring much benefit so left it. I may have a solution / workaround to the nesting issue for a follow up PR, if that doesn't pan out I'll fix this up then if that's alright.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveodonovan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
#803
When the main nav is collapsed to its rail presentation,
ensure we mark any link / menu with an active nav item
as active. This is to help orient users and help guide
them to the relevant section in the expanded nav.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.