Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture video of failed E2E tests #2470

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Sep 15, 2022

Changes

Update Cypress config to record video, but delete if a spec passes.

Mount the prow artifacts folder so we upload videos on failure.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2022
@AlanGreene AlanGreene added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2022
@AlanGreene AlanGreene force-pushed the cypress_artifacts branch 2 times, most recently from 8dc4355 to 132f0a4 Compare September 15, 2022 16:19
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2022
@AlanGreene AlanGreene force-pushed the cypress_artifacts branch 5 times, most recently from 23f275f to 6b09294 Compare September 15, 2022 19:37
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 15, 2022
@AlanGreene AlanGreene changed the title Test storing video from E2E runs Capture video of failed E2E tests Sep 15, 2022
Update Cypress config to record video, but delete if a spec passes.

Mount the prow artifacts folder so we upload videos on failure.
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2022
@tekton-robot tekton-robot merged commit 38299cb into tektoncd:main Sep 16, 2022
@AlanGreene AlanGreene deleted the cypress_artifacts branch September 16, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants