Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure e2e tests set default language to English #2474

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

AlanGreene
Copy link
Member

Changes

To ensure consistency and prevent issues with contributors running e2e tests on other platforms, configure the default language for all tests so that content-based assertions and locators work as expected.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

See the contribution guide
for more details.

To ensure consistency and prevent issues with contributors running
e2e tests on other platforms, configure the default language for all
tests so that content-based assertions and locators work as expected.
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 17, 2022
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2022
@tekton-robot tekton-robot merged commit f161c56 into tektoncd:main Sep 19, 2022
@AlanGreene AlanGreene deleted the e2e_language branch September 19, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants