Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide default value for ARTIFACTS variable if missing #2482

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Provide default value for ARTIFACTS variable if missing #2482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ source $(dirname $0)/e2e-common.sh

# Script entry point.

ARTIFACTS="${ARTIFACTS:-`mktemp -d`}"
SED="sed"
START=1
END=30
Expand Down Expand Up @@ -166,6 +167,7 @@ test_dashboard() {
VIDEO_PATH=$ARTIFACTS/videos
mkdir -p $VIDEO_PATH
chmod -R 777 $VIDEO_PATH
echo "Videos of failing tests will be stored at $VIDEO_PATH"
# In case of failure we'll upload videos of the failing tests
# Our Cypress config will delete videos of passing tests before exiting
docker run --rm --network=host -v $VIDEO_PATH:/home/node/cypress/videos dashboard-e2e || fail_test "Browser E2E tests failed"
Expand Down