Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify copyToClipboard util #2498

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Conversation

AlanGreene
Copy link
Member

Changes

All supported browsers now provide access to the clipboard API via navigator.clipboard so we no longer need to use workarounds involving textareas etc.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

See the contribution guide
for more details.

All supported browsers now provide access to the clipboard API
via `navigator.clipboard` so we no longer need to use workarounds
involving textareas etc.
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 1, 2022
@AlanGreene AlanGreene requested review from briangleeson and removed request for skaegi October 2, 2022 20:16
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 3, 2022
@tekton-robot tekton-robot merged commit a9d77c5 into tektoncd:main Oct 3, 2022
@AlanGreene AlanGreene deleted the clipboard branch October 3, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants