Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable golangci-lint in build tests #2509

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Oct 3, 2022

Changes

Related to #2429

Adopt similar config to other Tekton projects to run golangci-lint in the build tests job.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 3, 2022
@AlanGreene AlanGreene added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2022
@AlanGreene AlanGreene force-pushed the golangci-lint branch 2 times, most recently from 4e8a8d2 to 0606ac1 Compare October 3, 2022 17:07
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2022
@AlanGreene AlanGreene force-pushed the golangci-lint branch 2 times, most recently from 1403d01 to 83eef9b Compare October 3, 2022 17:18
Adopt similar config to other Tekton projects to run golangci-lint
in the build tests job.
@AlanGreene AlanGreene removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2022
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2022
@tekton-robot tekton-robot merged commit f0eba40 into tektoncd:main Oct 4, 2022
@AlanGreene AlanGreene deleted the golangci-lint branch October 4, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants