Replace fetch-mock with msw in tests #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/XL
Use mock service worker (`msw`) in tests to more closely replicate a real environment, mocking at the network level instead of at the API level. This gives greater visibility into tests that are not properly isolated, avoids issues specific to `fetch` or whichever request library is being used, and could also be used for e2e testing in future. Another motivation behind the change is the fact that `fetch-mock` hasn't been updated in about 2 years and uses a number of deprecated packages including `querystring` which will no longer receive updates for vulnerabilities.
|
/test pull-tekton-dashboard-integration-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use mock service worker (
msw) in tests to more closely replicate a real environment, mocking at the network level instead of at the API level.This gives greater visibility into tests that are not properly isolated, avoids issues specific to
fetchor whichever request library is being used, and could also be used for e2e testing in future.Another motivation behind the change is the fact that
fetch-mockhasn't been updated in about 2 years and uses a number of deprecated packages includingquerystringwhich will no longer receive updates for vulnerabilities.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
See the contribution guide
for more details.