Update timeout support for CreatePipelineRun and CreateTaskRun #2616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PipelineRun.spec.timeout
was deprecated in Pipelines v0.36.0, and replaced with a newPipelineRun.spec.timeouts
which allows setting timeouts for the entirepipeline
, for itstasks
, forfinally
tasks, or any combination of these.Update the UI to provide the additional input fields for the new values and remove the existing validation as these fields are not specified as numeric values representing minutes, instead they support a duration syntax provided by Go's
ParseDuration
, e.g.1h20m30s
.Update the CreateTaskRun page to support this format too instead of restricting the user to entering minutes.
Fix some redundant 'optional' labels on input fields.
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes