Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of waiting string in pod resource tab #2625

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

AlanGreene
Copy link
Member

Changes

Previous change to remove the managedFields from the pod resource tab inadvertently affected the display of the string in the waiting state, treating it as an array and displaying one character per line.

Update the code to correctly handle this case and display a string input as provided. Add test to cover this and prevent future regression.

image

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fix display of waiting state in pod resource tab so the message is displayed on a single line instead of one character per line

Previous change to remove the managedFields from the pod resource tab
inadvertently affected the display of the string in the waiting state,
treating it as an array and displaying one character per line.

Update the code to correctly handle this case and display a string
input as provided. Add test to cover this and prevent future regression.
@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2022
@AlanGreene AlanGreene requested review from briangleeson and removed request for skaegi December 9, 2022 12:11
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@tekton-robot tekton-robot merged commit 378a031 into tektoncd:main Dec 12, 2022
@AlanGreene AlanGreene deleted the pod_waiting branch December 12, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants