Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump css-loader from 6.7.2 to 6.7.3 #2639

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2022

Bumps css-loader from 6.7.2 to 6.7.3.

Release notes

Sourced from css-loader's releases.

v6.7.3

6.7.3 (2022-12-14)

Bug Fixes

Changelog

Sourced from css-loader's changelog.

6.7.3 (2022-12-14)

Bug Fixes

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes dependencies Used by dependabot - identifies all PRs created by dependabot javascript Pull requests that update Javascript code kind/misc Categorizes issue or PR as a miscellaneuous one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Dec 18, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign alangreene after the PR has been reviewed.
You can assign the PR to them by writing /assign @alangreene in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2022
@tekton-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

/test pull-tekton-dashboard-integration-tests

1 similar comment
@AlanGreene
Copy link
Member

/test pull-tekton-dashboard-integration-tests

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/css-loader-6.7.3 branch from 373d7ec to ae92ae0 Compare January 3, 2023 13:39
@AlanGreene
Copy link
Member

@dependabot recreate

Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 6.7.2 to 6.7.3.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/css-loader@v6.7.2...v6.7.3)

---
updated-dependencies:
- dependency-name: css-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/css-loader-6.7.3 branch from ae92ae0 to a4f2ae6 Compare January 3, 2023 14:24
@tekton-robot
Copy link
Contributor

@dependabot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-dashboard-integration-tests a4f2ae6 link true /test pull-tekton-dashboard-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AlanGreene
Copy link
Member

AlanGreene commented Jan 3, 2023

The Create PipelineRun e2e tests are failing, consistently 1 of the 4 specs fails, but all are passing consistently on all other PRs run today. The issue is not related to the dependency update in this PR as the styles are loaded correctly.

Tested locally with this change and the tests are passing consistently as expected. Including this change in another PR with some other dependency updates 🤞 Hopefully this PR was just getting stuck on a bad node…

Edit: Looks like it may have been a timing issue, potential fix included in #2647 which ensures we wait for navigation to complete after clicking 'Create', and then wait for a clickable link on the PipelineRuns table before proceeding instead of immediately clicking the first element containing the target text (which may just be a span if the URL isn't available yet).

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 4, 2023

Looks like css-loader is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Jan 4, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/css-loader-6.7.3 branch January 4, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes dependencies Used by dependabot - identifies all PRs created by dependabot javascript Pull requests that update Javascript code kind/misc Categorizes issue or PR as a miscellaneuous one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants