Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PipelineResources #2666

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Jan 10, 2023

Changes

Remove support for PipelineResources from the Dashboard. They have been deprecated
since Tekton Pipelines v0.30.0 in November 2021.

This also involves updating the Import Resources functionality to use a Task
instead of PipelineResources (git). The Task uses the git-init image also used
by the git-clone Task in the catalog.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Remove PipelineResources support from the UI. This includes their list and details pages, the Resources tabs on the PipelineRun and TaskRun details pages, as well as the form-based Create PipelineRun and Create TaskRun pages. Update Import Resources to use a Task instead of PipelineResources for the git clone operation.

@tekton-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/misc Categorizes issue or PR as a miscellaneuous one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 10, 2023
@AlanGreene AlanGreene removed the request for review from skaegi January 10, 2023 17:08
@AlanGreene
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2023
@AlanGreene AlanGreene marked this pull request as ready for review January 12, 2023 15:33
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2023
Remove support for PipelineResources from the Dashboard. They have been deprecated
since Tekton Pipelines v0.30.0 in November 2021.

This also involves updating the Import Resources functionality to use a Task
instead of PipelineResources (git). The Task uses the git-init image also used
by the git-clone Task in the catalog.
@AlanGreene
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2023
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Looks good from scanning through 👍

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2023
@tekton-robot tekton-robot merged commit 09ef68e into tektoncd:main Jan 13, 2023
@AlanGreene AlanGreene deleted the pipelineresources branch January 13, 2023 16:10
@lj19950508
Copy link

Will there be a similar feature replacement? i need this feature to manage resource and create taskrun

@AlanGreene
Copy link
Member Author

Hi @lj19950508, there are a number of options depending on your specific needs.

If you're using a Tekton Pipelines release which still supports PipelineResources you can use an older Tekton Dashboard release which still provides this functionality. Tekton Dashboard v0.30 LTS is the only supported version which still displays PipelineResources, and has been tested with Tekton Pipelines v0.38.x - v0.41.x. It will be end-of-life in October this year.

If you're using a recent Tekton Pipelines release which has removed support for PipelineResources there are different options depending on which PipelineResource types you were using. Most of the PipelineResource types have one or more Tasks in the Tekton Catalog that can be used as replacements. See the docs for some examples and additional guidance: https://tekton.dev/docs/pipelines/pipelineresources/

If you run into any problems feel free to join the Tekton Slack workspace (for example the #dashboard or #pipeline channels) or open a discussion on GitHub. If your questions are related to the Tekton Pipelines API and features they're probably better suited to the tektoncd/pipeline repo, or if they're related to the Dashboard's features you can use this repo.

@lj19950508
Copy link

i need form-based Create PipelineRun and Create TaskRun pages

@AlanGreene
Copy link
Member Author

AlanGreene commented Jun 9, 2023

If you need form-based Create pages with support for PipelineResources you'll need to use Dashboard v0.30 as that's the only remaining version that still supports PipelineResources.

To be clear, this functionality was removed from the Dashboard because it was also being removed from Tekton Pipelines. Recent versions of Tekton Pipelines no longer support PipelineResources.

The Dashboard still provides a form-based Create experience but it only supports basic inputs such as string params. For more advanced use (workspaces etc.) there's a button to switch to YAML mode where you can enter any valid PipelineRun / TaskRun YAML supported by your environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants