Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from v1alpha1 Run to v1beta1 CustomRun #2712

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

AlanGreene
Copy link
Member

Changes

#1970

Update permissions, navigation, APIs, etc. to switch from the deprecated v1alpha1 Run resources to the new v1beta1 CustomRun resources introduced in Tekton Pipelines v0.43.0

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Switch from the deprecated v1alpha1 Run resource to the new v1beta1 CustomRun resource introduced in Tekton Pipelines v0.43.0.

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2023
@AlanGreene
Copy link
Member Author

/hold
Additional change required to pick up correct Custom Task details (API version, Kind, etc.) for display

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2023
@AlanGreene
Copy link
Member Author

image
image

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2023
Update permissions, navigation, APIs, etc. to switch from the
deprecated v1alpha1 `Run` resources to the new v1beta1 `CustomRun`
resources introduced in Tekton Pipelines v0.43.0

The `ref` and `spec` fields in the CustomRun spec have been renamed
to `customRef` and `customSpec` respectively. Update code to use these
so the correct version and kind information is displayed.

`.status.startTime` is now optional so switch to sorting on
`.metadata.creationTimestamp`
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 9, 2023
@tekton-robot tekton-robot merged commit 488f61e into tektoncd:main Feb 9, 2023
@AlanGreene AlanGreene deleted the customruns branch February 9, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants