Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YAML mode for Create TaskRun #2735

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Add YAML mode for Create TaskRun #2735

merged 1 commit into from
Feb 20, 2023

Conversation

AlanGreene
Copy link
Member

Changes

Related to #1283, #2171, and #2437
Similar to Create PipelineRun, add a button to the Create TaskRun page allowing the user to switch to YAML mode for more advanced use cases not currently supported by the form-based UI.

Also add the 'Edit and run' action on the TaskRuns page allowing users to create a new TaskRun based on an existing one.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Add ability to create a TaskRun from YAML.
When switching to YAML mode on the Create TaskRun page, pre-populate the editor with either a basic TaskRun outline, or YAML corresponding to the selected inputs on the form.

Add new action for TaskRun - Edit and run
Add ability to edit a TaskRun and re-submit it

@tekton-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2023
@AlanGreene AlanGreene removed the request for review from skaegi February 16, 2023 17:10
@AlanGreene
Copy link
Member Author

/test all

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2023
@AlanGreene
Copy link
Member Author

/test all

@AlanGreene AlanGreene marked this pull request as ready for review February 17, 2023 11:00
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2023
@AlanGreene AlanGreene removed the request for review from skaegi February 17, 2023 11:01
briangleeson
briangleeson requested changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small suggestions

src/api/taskRuns.js Outdated Show resolved Hide resolved
src/api/taskRuns.js Outdated Show resolved Hide resolved
@AlanGreene
Add YAML mode for Create TaskRun
618beb1 
Similar to Create PipelineRun, add a button to the Create TaskRun
page allowing the user to switch to YAML mode for more advanced
use cases not currently supported by the form-based UI.

Also add the 'Edit and run' action on the TaskRuns page allowing
users to create a new TaskRun based on an existing one.
@AlanGreene
Copy link
Member Author

node/npm not installed properly
/test tekton-dashboard-unit-tests

@AlanGreene
Copy link
Member Author

node/npm not installed properly again, but different job this time... this has happened on a few PRs this morning so I'll need to dig into it a bit more
rerunning the job for now
/test pull-tekton-dashboard-integration-tests

briangleeson
briangleeson approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
@tekton-robot tekton-robot merged commit 1e10ff7 into tektoncd:main Feb 20, 2023
@AlanGreene AlanGreene deleted the taskrun_create_yaml branch February 20, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangleeson briangleeson briangleeson approved these changes

@LyndseyBu LyndseyBu Awaiting requested review from LyndseyBu

Assignees

@briangleeson briangleeson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanGreene @tekton-robot @briangleeson