Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup E2E tests and scripts #2813

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

AlanGreene
Copy link
Member

Changes

  • Remove use of envsubst in E2E test script which used either kubectl or curl to create resources on the cluster then queries the Dashboard API to retrieve them. Instead implement the test in Cypress and remove all of the related setup, dependencies, etc.
  • Create custom Cypress commands for common use of kubectl in the tests, i.e. create/delete namespace, apply resource.
  • Update Cypress to latest release
  • Update docs to remove reference to the old integration tests and remove the local script as all tests can now be run via Cypress which is already documented in a later section of the same doc.

/kind misc
/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. labels Mar 20, 2023
- Remove use of `envsubst` in E2E test script which used either
`kubectl` or `curl` to create resources on the cluster then queries
the Dashboard API to retrieve them. Instead implement the test in
Cypress and remove all of the related setup, dependencies, etc.
- Create custom Cypress commands for common use of `kubectl` in the
tests, i.e. create/delete namespace, apply resource.
- Update Cypress to latest release
- Update docs to remove reference to the old integration tests and
remove the local script as all tests can now be run via Cypress which
is already documented in a later section of the same doc.
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2023
@tekton-robot tekton-robot merged commit c9a55e9 into tektoncd:main Mar 20, 2023
@AlanGreene AlanGreene deleted the e2e_remove_envsubst branch March 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants