Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace git-init image in import resources #2886

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

AlanGreene
Copy link
Member

Changes

The git-init image is no longer published as part of the Pipelines release (it was part of the git PipelineResource support which has been removed).

Switch to cgr.dev/chainguard/git which provides the git client and is regularly updated for security fixes etc.

Implement the same functionality we previously had using pure git commands.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

The `git-init` image is no longer published as part of the Pipelines
release (it was part of the git PipelineResource support which has been
removed).

Switch to `cgr.dev/chainguard/git` which provides the git client and
is regularly updated for security fixes etc.

Implement the same functionality we previously had using pure git commands.
@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Apr 26, 2023
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 26, 2023
@AlanGreene
Copy link
Member Author

Failed downloading Node.js tar again, hopefully not becoming a regular issue…
/test tekton-dashboard-unit-tests

Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2023
@AlanGreene
Copy link
Member Author

/test tekton-dashboard-unit-tests

1 similar comment
@AlanGreene
Copy link
Member Author

/test tekton-dashboard-unit-tests

@AlanGreene
Copy link
Member Author

/test pull-tekton-dashboard-integration-tests

@tekton-robot tekton-robot merged commit f514fc7 into tektoncd:main Apr 26, 2023
@AlanGreene AlanGreene deleted the git_init_replacement branch April 26, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants