Reduce noise in unit test logs #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/misc
The logs contain a number of the following type of error:
```
Error: Not implemented: window.computedStyle(elt, pseudoElt)
at module.exports
(/home/prow/go/src/github.com/tektoncd/dashboard/node_modules/jsdom/lib/jsdom/browser/not-implemented.js:9:17)
at Window.getComputedStyle
(/home/prow/go/src/github.com/tektoncd/dashboard/node_modules/jsdom/lib/jsdom/browser/Window.js:798:7)
at getComputedStyle
(/home/prow/go/src/github.com/tektoncd/dashboard/node_modules/carbon-components-react/lib/components/Tooltip/Tooltip.js:81:55)
```
This is caused by the Carbon Tooltip component passing a second argument to
`getComputedStyle` referencing a pseudo element. This is not implemented in
jsdom resulting in the errors.
Since this shouldn't affect the tests, strip the second argument when calling
`getComputedStyle` in the tests to resolve the error and reduce noise in the logs.
AlanGreene
force-pushed
the
unit_test_logs_getComputedStyle
branch
from
cda9f85
to
e1a46dc
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The logs contain a number of the following type of error:
This is caused by the Carbon Tooltip component passing a second argument to
getComputedStylereferencing a pseudo element. This is not implemented in jsdom resulting in the errors.Since this shouldn't affect the tests, strip the second argument when calling
getComputedStylein the tests to resolve the error and reduce noise in the logs./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes