-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send start and completion time to external logs proxy #2909
Send start and completion time to external logs proxy #2909
Conversation
Hi @AverageMarcus. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AverageMarcus, thanks for the contribution (including tests!). Overall this approach looks good, should be backwards compatible, and could be useful to other users, so it makes sense to include it 👍
I've made a few small suggestions below, let me know if you have any questions.
Include the TaskRuns start time and completion time as properties sent to the external logs proxy to allow for more fine-tuned queries to be run against a long-term log store. Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
4e0cb63
to
2d8ee87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Marcus
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlanGreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Fixes #2908
Include the
startTime
andcompletionTime
of the TaskRun when calling out to the external logs proxy so that queries against the long-term log storage can be optimised to search a targeted timeframe if possible.These are included as query parameters to allow for backwards-compatibility with existing route handling logic that might be being used.
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes