Add support for TEP-0047 'displayName' #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When viewing a Pipeline or Task details page, include the 'displayName' alongside the 'description' if provided. On the PipelineRun details page, show the 'displayName' in the TaskTree instead of the pipelineTaskName. This also accounts for retries where the 'displayName' is used as the base instead. The details to the right still show the full TaskRun name as before. A future change may include display of the pipelineTask description so this is wired up but its display is omitted for now.
tekton-robot
added
kind/feature
|
/test tekton-dashboard-unit-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #2792
When viewing a Pipeline or Task details page, include the 'displayName' alongside the 'description' if provided.
On the PipelineRun details page, show the 'displayName' in the TaskTree instead of the pipelineTaskName. This also accounts for retries where the 'displayName' is used as the base instead.
The details to the right still show the full TaskRun name as before.
A future change may include display of the pipelineTask description so this is wired up but its display is omitted for now.
/kind feature
Before:
After:
Retries:
Also supports a mixture of pipeline tasks with displayName and without:
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes