Delete .ko.yaml #2997
Closed
Delete .ko.yaml #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
size/XS
The default base image for `ko` since v0.12.0 is `cgr.dev/chainguard/static` This is a very lightweight base image with just the bare minimum required to run static binaries. It also runs as nonroot by default so matches the previous image. Comparison of base image sizes (output from `docker images`): ``` cgr.dev/chainguard/static latest 90320c6851cc 6 weeks ago 3.06 MB gcr.io/distroless/base-debian11 nonroot 053d24ed112e 4 seconds ago 19.3 MB ``` Comparison of built Dashboard image (using installer script with default settings): ``` root@tekton-dashboard-control-plane:/# crictl images | grep dashboard kind.local/dashboard-9623576a202fe86c8b7d1bc489905f86 latest 921213af83dc0 23.2MB kind.local/dashboard-9623576a202fe86c8b7d1bc489905f86 94370ac46698f930b2b8366a1f6d2a9ca3f24080c20a440106bc1599d8decc76 921213af83dc0 23.2MB kind.local/dashboard-9623576a202fe86c8b7d1bc489905f86 ecc31e47e5b7e50c1b9c92805d3c4b69d6425f9757677fdaa800b008d198487c e5e5e2f4101d1 31.3MB ``` This gives an over 25% reduction in the final image size.
AlanGreene
force-pushed
the
ko_baseimage_update
branch
from
9d91a31
to
07386f1
Compare
|
Tide was restarted and seems to be in better shape now, the original PR is unblocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replacement for #2996 which is stuck with
The default base image for
kosince v0.12.0 iscgr.dev/chainguard/staticThis is a very lightweight base image with just the bare minimum required to run static binaries. It also runs as nonroot by default so matches the previous image.Comparison of base image sizes (output from
docker images):Comparison of built Dashboard image (using installer script with default settings):
This gives an over 25% reduction in the final image size.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes