Remove use of defaultProps in functional components #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/misc
packages/components/src/components/TaskRunDetails/TaskRunDetails.js
Outdated
Show resolved
Hide resolved
defaultProps for functional components will be deprecated in react 18.3.0
and the recommendation is to use JavaScript native support for default
parameters instead.
One additional issue to bear in mind is that the default values must be
serially stable, i.e. non-primitive values should not be set inline,
otherwise the prop would appear to have a new value on each re-render.
This means things like `[]`, `{}`, and `() => {}` should be defined outside
the function params.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
defaultProps for functional components will be deprecated in react 18.3.0 and the recommendation is to use JavaScript native support for default parameters instead.
One additional issue to bear in mind is that the default values must be serially stable, i.e. non-primitive values should not be set inline, otherwise the prop would appear to have a new value on each re-render.
This means things like
[],{}, and() => {}should be defined outside the function params./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes