Update tests to remove references to deprecated bundles feature #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bundles feature is deprecated, replaced by remote resolution. As part of this the `pipelineRef.bundle` and `taskRef.bundle` fields are deprecated. These tests were originally added to handle the case of runs created from pipeline / task definitions loaded via bundles, but are not actually specific to that functionality and cover multiple cases where the pipeline / task definition is not available separately. Rename the tests to make this clearer and remove the deprecated fields which didn't actually impact on the functionality at all.
tekton-robot
added
kind/misc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The bundles feature is deprecated, replaced by remote resolution. As part of this the
pipelineRef.bundleandtaskRef.bundlefields are deprecated.These tests were originally added to handle the case of runs created from pipeline / task definitions loaded via bundles, but are not actually specific to that functionality and cover multiple cases where the pipeline / task definition is not available separately.
Rename the tests to make this clearer and remove the deprecated fields which didn't actually impact on the functionality at all.
These fields may be removed from Tekton Pipelines in any future release as the notice period has expired. See https://github.com/tektoncd/pipeline/blob/080ea1367aa342915fe86c8da583ee3401983946/docs/deprecations.md for details of the deprecation.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes