Remove Node.js install from build tests #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
kind/misc
tekton-robot
added
the
size/XS
AlanGreene
force-pushed
the
build_tests_node
branch
from
944a6b4
to
8c33616
Compare
tekton-robot
added
lgtm
|
/test tekton-dashboard-unit-tests |
1 similar comment
|
/test tekton-dashboard-unit-tests |
tekton-robot
added
size/M
|
Flaky test, hopefully fixed in #3040 |
The build tests script does not require Node.js so there's no need to install it during setup. Remove the call to `get_node` from the `extra_initialization` function which is called for all tests types. Add `get_node` to the function responsible for running npm install which is called for all tests types that require Node.js (unit + integration) Also remove unnecessary apt commands installing curl which is already included in the test runner image.
AlanGreene
force-pushed
the
build_tests_node
branch
from
5d81622
to
9f0b37f
Compare
tekton-robot
added
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The build tests script does not require Node.js so there's no need to install it during setup.
Remove the call to
get_nodefrom theextra_initializationfunction which is called for all tests types.Add
get_nodeto the function responsible for running npm install which is called for all tests types that require Node.js (unit + integration)/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes