Improve performance of SASS build step #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swap `sass` (pure JavaScript) for `sass-embedded` (JavaScript wrapper around a native Dart executable) to significantly improve build times. Installed by using an alias since the sass implementation used by vite is not currently configurable: `npm i sass@npm:sass-embedded` For comparison on one machine: | Command | Before | After | |---|---|---| | `npm start` | 25-35s | ~1s | | `npm run build` | 40-50s | ~10s | Both packages are built by the same team, use the same underlying Dart implementation, and are released at the same time.
tekton-robot
added
kind/misc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test tekton-dashboard-unit-tests |
|
Results in CI
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Swap
sass(pure JavaScript) forsass-embedded(JavaScript wrapper around a native Dart executable) to significantly improve build times.Installed by using an alias since the sass implementation used by vite is not currently configurable:
npm i sass@npm:sass-embeddedFor comparison on one machine:
npm startnpm run buildBoth packages are built by the same team, use the same underlying Dart implementation, and are released at the same time.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes