Add Dockerfile for e2e base image #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a Dockerfile which will be used to create the base images used for running the e2e tests. This allows us direct control over the Chrome and Node.js versions used instead of waiting for Cypress to release a new image which happens very infrequently. Move the kubectl install and much of the other config into this Dockerfile so that the one used to package the tests is more focused and doesn't have to duplicate the foundations each time the tests run. Pipeline definitions and related config to build and publish the image will follow separately.
tekton-robot
added
kind/misc
|
Timed out waiting for the second run to complete, will add this to the list of tests to watch for flake (first time it's failed in PR jobs). This change has no impact on any existing tests. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related to #3283
Add a Dockerfile which will be used to create the base images used for running the e2e tests. This allows us direct control over the Chrome and Node.js versions used instead of waiting for Cypress to release a new image which happens very infrequently.
Move the kubectl install and much of the other config into this Dockerfile so that the one used to package the tests is more focused and doesn't have to duplicate the foundations each time the tests run.
Pipeline definitions and related config to build and publish the image will follow separately.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes