Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go 1.22 #3361

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Update to go 1.22 #3361

merged 1 commit into from
Mar 27, 2024

Conversation

AlanGreene
Copy link
Member

Changes

Update go to 1.22
Update other back-end build dependencies:

  • ko 0.15
  • kustomize 5.3
  • golangci-lint 1.57

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@AlanGreene
Update to go 1.22
89d9b8d 
Update go to 1.22
Update other back-end build dependencies:
- ko 0.15
- kustomize 5.3
- golangci-lint 1.57
@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Mar 22, 2024
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 22, 2024
@AlanGreene
Copy link
Member Author

AlanGreene commented Mar 22, 2024 •
edited
Loading

Expect at least some checks to fail until the test-runner image in the prow config is updated to gcr.io/tekton-releases/dogfooding/test-runner:v20240322-4be9251150@sha256:622c058fe4d02053819a88faf1a0edaccf09920904c666712750b3fbeb987c80

PR open: tektoncd/plumbing#1889

@AlanGreene
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2024
briangleeson
briangleeson approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@AlanGreene
Copy link
Member Author

/test all

@AlanGreene
Copy link
Member Author

Fix for latest failure: tektoncd/plumbing#1898
Caused by a change introduced by Docker 25 which is included in the latest test-runner image.

@AlanGreene
Copy link
Member Author

New image built, PR to bump Dashboard jobs to use it: tektoncd/plumbing#1899

@AlanGreene
Copy link
Member Author

/test all

@AlanGreene
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@tekton-robot tekton-robot merged commit ac3c95f into tektoncd:main Mar 27, 2024
8 checks passed
@AlanGreene AlanGreene deleted the go_1.22 branch March 27, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangleeson briangleeson briangleeson approved these changes

@LyndseyBu LyndseyBu Awaiting requested review from LyndseyBu

Assignees

@briangleeson briangleeson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanGreene @tekton-robot @briangleeson