Adopt CSS logical properties #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare for Carbon 11 upgrade, adopt CSS logical properties for consistency and to take advantage of some of the new auto-layout features. - `width` becomes `inline-size` - `margin-top` becomes `margin-block-start` - `top` and `right` become `inset-block-start` and `inset-inline-end` respectively - viewport units `vw` (width) and `vh` (height) become `vi` (inline) and `vb` (block) respectively - etc. Logical properties aren't supported in media queries yet so there are still some uses of `min-width` remaining for now. Similarly, the logical property replacements for `overflow-x` and `overflow-y` are currently only supported in Firefox, so we keep the existing properties for now and can implement a workaround to honour writing direction etc. if needed. Also update some variables and other identifiers in code to use the `start` / `end` naming for consistency. Some functions which are part of component APIs keep their original naming for now.
tekton-robot
added
kind/misc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prepare for Carbon 11 upgrade, adopt CSS logical properties for consistency and to take advantage of some of the new auto-layout features.
widthbecomesinline-sizemargin-topbecomesmargin-block-starttopandrightbecomeinset-block-startandinset-inline-endrespectivelyvw(width) andvh(height) becomevi(inline) andvb(block) respectivelyLogical properties aren't supported in media queries yet so there are still some uses of
min-widthremaining for now.Similarly, the logical property replacements for
overflow-xandoverflow-yare currently only supported in Firefox, so we keep the existing properties for now and can implement a workaround to honour writing direction etc. if needed.Also update some variables and other identifiers in code to use the
start/endnaming for consistency. Some functions which are part of component APIs keep their original naming for now./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes