Use react router's route handle functionality to remove duplicate containers #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tainers Configure the resource GVK on the relevant routes to enable use of a common container for most resource list pages. This also means that a number of custom hooks are no longer required. Ensure extensions work as expected in this new setup, correctly handling the namespace dropdown behaviour depending on whether the extension is for namespace-scoped or cluster-scoped resources. Rename params in paths to use consistent naming, i.e. `name` should always be used for the resource name to allow for common code to process this centrally without the need for resource-specific handling.
tekton-robot
added
kind/misc
briangleeson
approved these changes
Jul 1, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
lgtm
|
This resolves most of the blockers for #3381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#2452
Configure the resource GVK on the relevant routes to enable use of a common container for most resource list pages. This also means that a number of custom hooks are no longer required.
Ensure extensions work as expected in this new setup, correctly handling the namespace dropdown behaviour depending on whether the extension is for namespace-scoped or cluster-scoped resources.
Rename params in paths to use consistent naming, i.e.
nameshould always be used for the resource name to allow for common code to process this centrally without the need for resource-specific handling./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes