Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Carbon 11 #3501

Merged
merged 73 commits into from
Jul 23, 2024
Merged

Update to Carbon 11 #3501

merged 73 commits into from
Jul 23, 2024

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Jul 6, 2024

Changes

Closes #3493

/kind misc

Some of the remaining todo items are captured below.
There are more annotated TODO: carbon11 directly in the code.

Carbon:

Dashboard:

  • ViewYAML
    • need to right-align line numbers
  • Actions
    • overflowmenu styling
    • menu button styling
  • DeleteModal
    • button size
  • Header and SideNav should always use g100 theme
  • replace use of tkn--visually-hidden with cds--visually-hidden
  • NamespacesDropdown in app header - not selecting 'All namespaces' as default value when clearing selection
  • dropdowns on create pages not properly cleared when clicking the 'clear' button
  • logs toolbar button styles
  • graph components

Tests:

  • Unit tests
    • current status: 1 additional test skipped due to change in ComboBox behaviour described above, all other tests now passing
      Test Files  73 passed (73)
      Tests  579 passed | 2 skipped (581)
      
  • E2E tests
    • current status: green
  • Linters
    • current status: clean
  • Storybook
    • current status:
      • dev mode building successfully with graph components excluded
      • all most stories functional
      • some styling issues to be resolved
      • all stories rendering some stories not rendering (e.g. resourcedetails default)
      • some functional issues (unable to switch tabs in some stories)
  • cross-browser testing
    • Carbon Tab style issues in Firefox, reproducible on Carbon storybook
    • Carbon Table batch action button focus styles (black outline instead of expected white / gray), reproduced in Chrome, haven't tested other browsers yet
  • a11y, full pass including but not limited to:
    • keyboard navigation
    • colour contrast
    • screen reader

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jul 6, 2024
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 6, 2024
Also remove `@carbon/themes` as we'll consume that via `@carbon/react` instead
Also replace custom `getCarbonPrefix` util with the provided context
and hook.
Note: skipping step 2 as we're already using dart sass

- Update the base imports to use the new package.
- Minimal changes to resolve warnings about unknown imports (mostly
the component styles)
- Fix the theme classes
At this point the application builds and loads successfully in the browser.
The styling is far from perfect but the major pieces are in place.
There are also a number of functional issues due to changes in component
APIs / behaviours, e.g. tab lists do not currently render.
This concludes the short version of the migration guide,
for the core application only (graph package will be done later).

Unit test status:
```
Test Files  20 failed | 53 passed (73)
Tests  57 failed | 524 passed | 1 skipped (582)
```
The `$fallback` config is meant for use with the compatibility theme.
Temporarily disable the graph stories. That package will be upgraded later.
These may be update to the new CSS grid-based Grid component later.
Update the ResourceDetails, StepDetails, and TaskRun details stories
to use the Storybook API to update the `view` prop when selecting a tab.
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the walkthrough. A few queries, but looking good otherwise

This wasn't handled correctly by the Carbon code mods during migration.
Manually restore the expected size.
@AlanGreene
Copy link
Member Author

/test all

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
When navigating the tab list with the arrow keys, the default behaviour
of the Carbon components is to load the tab panel corresponding with the
currently focused tab.

Since some of the tab content in the Dashboard triggers additional network
requests when rendered (e.g. step logs tab), set `activation="manual"` so
that the user must click (or press space / enter) to activate the tab.
Includes fixes for:
- Unexpected page scroll when using arrow keys to navigate MenuButton items
- Wrong tab styles in Firefox
@AlanGreene
Copy link
Member Author

/hold cancel

@AlanGreene
Copy link
Member Author

/test all

@AlanGreene AlanGreene marked this pull request as ready for review July 22, 2024 22:16
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2024
@AlanGreene
Copy link
Member Author

/retest

@AlanGreene AlanGreene removed the request for review from skaegi July 23, 2024 09:15
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

👍

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit df8b56f into tektoncd:main Jul 23, 2024
8 checks passed
@AlanGreene AlanGreene deleted the carbon11 branch July 23, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Carbon
3 participants