Update Vite to 5.4 and Carbon to 1.63 #3540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
tekton-robot
added
do-not-merge/work-in-progress
tekton-robot
added
the
size/S
Vite 5.4 natively supports `sass-embedded` so we no longer need to install it aliased as `sass`. This simplifies things as we can rely on dependabot to update it and avoid some issues with deduping the dependency in the tree. Although some packages, such as Carbon and Storybook, still reference `sass` directly, Vite now prioritises `sass-embedded` if found. As part of this update we also update Carbon and related packages to remove remaining references to the aliased `sass-embedded` to clean up the dependency tree.
AlanGreene
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Vite 5.4 natively supports
sass-embeddedso we no longer need to install it aliased assass. This simplifies things as we can rely on dependabot to update it and avoid some issues with deduping the dependency in the tree.Although some packages, such as Carbon and Storybook, still reference
sassdirectly, Vite now prioritisessass-embeddedif found.As part of this update we also update Carbon and related packages to remove remaining references to the aliased
sass-embeddedto clean up the dependency tree./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes