Convert more components to functional components #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
tekton-robot
added
kind/misc
Convert some of the remaining class-based React components to functional components, ensuring no change in props or functionality. This also allows us to reduce the number of instances of the `injectIntl` HOC in favour of the preferred `useIntl` hook. A side effect of this is that some of the stories on the Storybook welcome page now render their code correctly without the `injectIntl` wrapper.
AlanGreene
force-pushed
the
functional_components
branch
from
e360b5f
to
a34beb4
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Depends on #3568
Convert some of the remaining class-based React components to
functional components, ensuring no change in props or functionality.
This also allows us to reduce the number of instances of the
injectIntlHOC in favour of the preferred
useIntlhook. A side effect of thisis that some of the stories on the Storybook welcome page now render
their code correctly without the
injectIntlwrapper./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes