Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort matrix TaskRuns by display name on the PipelineRun details page #3615

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Sep 16, 2024

Changes

Related to #3613

To ensure a stable order when showing the matrix TaskRuns in the UI, sort by display name. This should also work for custom tasks that produce multiple TaskRuns.

If there is no display name we maintain the source order, so there is no change to the user experience in that case.
/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Use TaskRun display names to provide a stable sort order when displaying matrixed TaskRuns on the PipelineRun details page.

To ensure a stable order when showing the matrix TaskRuns in the UI,
sort by display name. This should also work for custom tasks that
produce multiple TaskRuns.

If there is no display name we maintain the source order, so there is
no change to the user experience in that case.
@tekton-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2024
@AlanGreene AlanGreene requested review from LyndseyBu and removed request for skaegi September 16, 2024 17:26
@AlanGreene AlanGreene marked this pull request as ready for review September 17, 2024 12:26
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2024
@tekton-robot tekton-robot merged commit 611fbe2 into tektoncd:main Sep 17, 2024
8 checks passed
@AlanGreene AlanGreene deleted the matrix_displayName_order branch September 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants