Fix global namespaces dropdown loading styles #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the move to Carbon 11 the ComboBox and Dropdown skeleton states have changes, and the component props are slightly different. Remove the obsolete `inline` prop, and update the styles to account for the updated components to prevent the loading styles overflowing the header and causing a layout shift on other pages too.
tekton-robot
added
the
kind/misc
tekton-robot
added
the
size/S
AlanGreene
requested review from
briangleeson
and removed request for
skaegi
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With the move to Carbon 11 the ComboBox and Dropdown skeleton states have changes, and the component props are slightly different.
Remove the obsolete
inlineprop, and update the styles to account for the updated components to prevent the loading styles overflowing the header and causing a layout shift on other pages too./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes