Prepare for publishing images to GHCR #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regions are configurable in the publish task but one of the steps ignored the config. Fix this and expose the `imageRegistryRegions` param in the `Pipeline` so it can be provided by the `PipelineRun`.
WHen building the dashboard image with `ko`, add the OCI source label: `org.opencontainers.image.source=https://$(params.package)` This is generally useful, and in the case og ghcr.io it lets GitHub automatically associate the container image with its source repo.
The current release pipeline assumes that the same credentials are used to authenticate to the cloud storage service as well as to the container registry. This change enables having independent credentials. It also enables user PAT based auth for the container registry by making the user configurable instead of hardcoding `_json_key` which is used for gcr.
Add support for passing extra args to `ko` and move the existing args `--preserve-import-paths` to be the default for the publish task. This means we no longer need the `release` command in the installer script as the `--preserve-import-paths` arg will be passed in from the pipeline. This change means that the pipeline can now control `ko` settings and change the default path based on the registry.
|
Skipping CI for Draft Pull Request. |
tekton-robot
added
do-not-merge/work-in-progress
2 tasks
tekton-robot
removed
the
do-not-merge/work-in-progress
briangleeson
approved these changes
Sep 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related to tektoncd/plumbing#2157 and tektoncd/plumbing#2202
Modelled after similar changes already made for tektoncd/pipeline
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes