Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update E2E to use new base image with Node.js 20.18 and Chrome 130 #3721

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Update E2E to use new base image with Node.js 20.18 and Chrome 130 #3721

merged 1 commit into from
Oct 29, 2024

Conversation

AlanGreene
Copy link
Member

Changes

Follow-up to #3719 now that the new base image is published.
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 29, 2024
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2024
@AlanGreene AlanGreene requested review from LyndseyBu and removed request for skaegi October 29, 2024 13:32
briangleeson
briangleeson approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
@AlanGreene
Copy link
Member Author

AlanGreene commented Oct 29, 2024 •
edited
Loading

Node.js download failed, retrying…
/retest

@tekton-robot tekton-robot merged commit 6517719 into tektoncd:main Oct 29, 2024
8 checks passed
@AlanGreene AlanGreene deleted the e2e_chrome130_node20.18 branch October 29, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangleeson briangleeson briangleeson approved these changes

@LyndseyBu LyndseyBu Awaiting requested review from LyndseyBu

Assignees

@briangleeson briangleeson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanGreene @tekton-robot @briangleeson