Update Header styles to more closely match Carbon #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
the
size/L
carrenelloyd
approved these changes
Jan 24, 2020
AlanGreene
force-pushed
the
header_styles
branch
from
863e1b4
to
39e9f0b
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
AlanGreene
requested review from
steveodonovan
and removed request for
akihikokuroda and
jessm12
AlanGreene
added
the
do-not-merge/work-in-progress
- Remove height and background colour overrides on Header - Swap out header image for white version of logo - Update LogoutButton to use a header action
AlanGreene
force-pushed
the
header_styles
branch
from
39e9f0b
to
68b1b37
Compare
AlanGreene
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carrenelloyd, steveodonovan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Possible interim implementation while waiting for the components to implement #803
The breadcrumbs (as currently implemented, showing selected resource + type) seem redundant with this update as they're displayed right above the header which includes the exact same information:
So I've removed them for now...
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.